Re-extrapolate values for particles entering the inflow zone #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 69.36% 69.25% -0.12%
==========================================
Files 100 100
Lines 6421 6433 +12
==========================================
+ Hits 4454 4455 +1
- Misses 1967 1978 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svchb
requested changes
Apr 11, 2025
Comment on lines
+258
to
+260
| extrapolate_values!(system, v, v_fluid, u, u_fluid, | ||
| semi, t; particle_iterator=system.particle_iterator, | ||
| system.cache...) |
There was a problem hiding this comment.
Extrapolation is not correct results in 0 pressure
| extrapolate_values!(system, v, v_fluid, u, u_fluid, | ||
| semi, t; particle_iterator=system.particle_iterator, | ||
| system.cache...) | ||
| end |
There was a problem hiding this comment.
Suggested change
| end | |
| for particle in system.particle_iterator | |
| velocity = current_velocity(v, system, particle) | |
| density = particle_density(v, system, particle) | |
| pressure = particle_pressure(v, system, particle) | |
| @info "Extrapolated velocity for particle $particle" velocity | |
| @info "Extrapolated density for particle $particle" density | |
| @info "Extrapolated pressure for particle $particle" pressure | |
| end | |
| end |
Comment on lines
+389
to
+390
| @inline function transfer_particle!(system_new::FluidSystem, system_old, particle_old, | ||
| v_new, u_new, v_old, u_old, ::InFlow) |
There was a problem hiding this comment.
Suggested change
| @inline function transfer_particle!(system_new::FluidSystem, system_old, particle_old, | |
| v_new, u_new, v_old, u_old, ::InFlow) | |
| @inline function transfer_particle!(system_new, system_old::FluidSystem, particle_old, | |
| v_new, u_new, v_old, u_old, ::BoundaryZone{InFlow}) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.