Fix the validation setup based on Marrone2011 #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
=======================================
Coverage 70.25% 70.25%
=======================================
Files 106 106
Lines 6906 6906
=======================================
Hits 4852 4852
Misses 2054 2054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rixiParticles.jlOpen into validation_dam_break_fix
efaulhaber
requested changes
Jul 16, 2025
Comment on lines
+22
to
+69
| function pressure_probe(coord_top, coord_bottom, v_ode, u_ode, t, system, semi) end | ||
|
|
||
| function pressure_probe(coord_top, coord_bottom, v_ode, u_ode, t, | ||
| system::TrixiParticles.BoundarySystem, semi) | ||
| # The sensor is at the right wall, so its x-coordinate is the same for top and bottom. | ||
| x_sensor = coord_top[1] | ||
|
|
||
| # Use the initial particle spacing as a reference for the thickness of the averaging region. | ||
| # A thickness of one or two particle spacings is usually a good choice. | ||
| region_thickness = 2.0 * particle_spacing | ||
|
|
||
| # Define the rectangular region for averaging | ||
| x_min = x_sensor - region_thickness | ||
| x_max = x_sensor + region_thickness | ||
| y_min = coord_bottom[2] | ||
| y_max = coord_top[2] | ||
|
|
||
| sum_of_pressures = 0.0 | ||
| num_particles_in_region = 0 | ||
|
|
||
| v = TrixiParticles.wrap_v(v_ode, system, semi) | ||
| u = TrixiParticles.wrap_u(u_ode, system, semi) | ||
|
|
||
| # Iterate over each particle in the specified fluid system | ||
| for particle_idx in TrixiParticles.eachparticle(system) | ||
| pc = TrixiParticles.current_coords(u, system, particle_idx) | ||
|
|
||
| # Get coordinates for the current particle from the 1D vector | ||
| px = pc[1] # x-coordinate | ||
| py = pc[2] # y-coordinate | ||
|
|
||
| # Check if the particle is inside the sensor's rectangular region | ||
| if (x_min <= px <= x_max) && (y_min <= py <= y_max) | ||
| # Add its pressure to the sum and increment the count | ||
| sum_of_pressures += TrixiParticles.current_pressure(v, system, particle_idx) | ||
| num_particles_in_region += 1 | ||
| end | ||
| end | ||
|
|
||
| # If no particles are in the region (e.g., before the water hits the wall), | ||
| # the pressure is zero. | ||
| if num_particles_in_region == 0 | ||
| return 0.0 | ||
| end | ||
|
|
||
| # Return the calculated average pressure | ||
| return sum_of_pressures / num_particles_in_region | ||
| end |
There was a problem hiding this comment.
I don't think it makes any sense to include this particle-averaged pressure computation.
There was a problem hiding this comment.
Than remove it in your PR. I have it in all the reference files.
There was a problem hiding this comment.
But I can also remove it manually
Comment on lines
+9
to
+11
| # use at least 5 interpolation points for low resolution simulations | ||
| # otherwise use at least the number of particles present | ||
| n_interpolation_points = min(5, Int(ceil(sensor_size / particle_spacing))) |
There was a problem hiding this comment.
Why? I think 10 should be enough.
There was a problem hiding this comment.
You can change that in your PR all the files are generated with this setting.
svchb
changed the title
…rixiParticles.jlOpen into validation_dam_break_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the setup as provided by Marrone:
