Menu fix #61
Open
Menu fix #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove megatron_menu_navigation_links() and megatron_menu_navigation_links() - these were not allowing custom attributes to be added to links within the menus built with these functions (ie. target). Additionally, they were not built very well :/ Clean up comment style in template.php
occupant
commented
Jun 17, 2019
template.php
Outdated
| @@ -307,14 +307,14 @@ function megatron_preprocess_page(&$variables) { | |||
|
|
|||
| $variables['primary_nav'] = FALSE; | |||
| if ($variables['main_menu']) { | |||
| $menu_tree = menu_tree_page_data('main-menu'); | |||
| $menu_tree = menu_tree_page_data(variable_get('menu_primary_links_source', 'main-menu'); | |||
There was a problem hiding this comment.
Use the menu setting instead of hard coding the menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There's a bug in the menu system that is caused by the custom primary menu render function
megatron_megatron_links- basically we can't add additional attributes and the classes are pretty much hard-coded. It's just kind of bad all around.I had to clean it up for a project that required a
targetattribute on these links, so I took the opportunity to clean up the way the primary menus are rendered and remove both themegatron_megatron_links()andmegatron_menu_navigation_links()functions.Changes
megatron_megatron_links()functionmegatron_menu_navigation_links()functionmegatron_menu_linkLinks in the primary menu no longer get the
menu-[mlid]b070a2b] or node title (ie.
my-page-title) classes. The second one was always a bad idea, but both are possible breaking changes as there may be CSS using these as styling hooks.I'm hoping you can do a sanity check on these whenever you have a chance.
Cheers