Fix show vgrid/workgroup private file rendering #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
render html and txt files directly but force download of anything else.
jonasbardino
added this to the Python3 support for general research data sites milestone
jonasbardino
added
the
follow-up pending
|
This is a plain fix to get the issue quickly resolved, but we should add unit tests as follow-up. We can likely reuse the |
|
The failed sanity check is just some unused old SOAPpy import in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework showvgridprivatefile to emulate a simplified version of cat.py to render html and txt files directly but force download of anything else to address issue #258.