Skip to content

Add MERRA2 aerosol three hourly forcing to drive UFS #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Add MERRA2 aerosol three hourly forcing to drive UFS #2684

wants to merge 22 commits into from

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Apr 7, 2025 •
edited
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Commit Message:


  * FV3 - 
    * ccpp-physics -

Priority:

  • Normal

Git Tracking

Sub component Pull Requests:

#2683

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines for all tests with mraerosol=T.

Input data Changes:

  • New input data:
  • /scratch1/NCEPDEV/climate/Anning.Cheng/MERRA2_40y/2021_03/MERRA2_400.inst3_3d_aer_Nv.20210322.nc4
  • /scratch1/NCEPDEV/climate/Anning.Cheng/MERRA2_40y/2021_03/MERRA2_400.inst3_3d_aer_Nv.20210323.nc4

Library Changes/Upgrades:

No new library needed

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@AnningCheng-NOAA AnningCheng-NOAA mentioned this pull request Apr 18, 2025
Open
@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA Could you push the tests/logs/RegressionTests_*.log from the machine where you ran your regression tests please? Also, there are some missing sections of this template that code managers need to see completed (checkboxes, description, commit messages, submodule PR links).

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented May 2, 2025 via email

@AnningCheng-NOAA
Copy link
Contributor Author

I am able to compile the code and regression tests passed in Orion, still not know why the trunk does not pass compilation in hera.

@AnningCheng-NOAA
Copy link
Contributor Author

just pass regression tests in hera and push the log file.

@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA It looks like the regression test logs that you uploaded are only showing results for the new test (merra2_hf_thompson). We actually need logs for the entire rt.conf test suite, including your new test. I'm guessing that the only test that should change results should be the merra2_hf_thompson test, right? If so, the test_changes.list file should only contain that test.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented May 16, 2025 via email

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA can you sync up branch? so we can do a pre test to make sure.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented May 19, 2025 via email

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 Please make sure that the description is added and labels are added. Also please make sure the syncing of develop was done successfully (There are a lot of artifacts from improper code merges). Please let me know when Hera input-data has the new input data for this PR so I can sync it on WCOSS2.

@grantfirl
Copy link
Collaborator

@jkbk2004 Please make sure that the description is added and labels are added. Also please make sure the syncing of develop was done successfully (There are a lot of artifacts from improper code merges). Please let me know when Hera input-data has the new input data for this PR so I can sync it on WCOSS2.

@jkbk2004 Ya, I see a bunch of little mistakes that have been committed. If you don't have time, I can try to clean up this PR. Let me know.

@grantfirl
Copy link
Collaborator

@jkbk2004 It's also not clear to me that testing has been done correctly. Since this is a ccpp-physics-started PR, I can try to run full RTs and upload the right logs. Again, just let me know.

jkbk2004
jkbk2004 reviewed May 19, 2025
View reviewed changes
@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented May 19, 2025 via email

@jkbk2004
Copy link
Collaborator

@jkbk2004 It's also not clear to me that testing has been done correctly. Since this is a ccpp-physics-started PR, I can try to run full RTs and upload the right logs. Again, just let me know.

@grantfirl it will be great if a full test can be run. Let me know if it's too busy on your side.

@grantfirl
Copy link
Collaborator

@jkbk2004 @AnningCheng-NOAA I think that this is cleaned up now. I've started the full rt.conf on Hera and will push new logs when finished.

@grantfirl
Copy link
Collaborator

@jkbk2004 @AnningCheng-NOAA There were many RT failures with this code. The failures that I checked on didn't even run because the mraerosol environment variable isn't being set in tests/default_vars.sh. It looks like mraerosol setting from the environment was added to global_control.nml.IN, but for tests where mraerosol should be false, the environment variable isn't set yet. @AnningCheng-NOAA I think that you need to add statements in tests/default_vars.sh to set mraerosol to false where necessary. As a guide, you should be able to (mostly?) copy what is being done for the ltaerosol variable, right?

@grantfirl
Copy link
Collaborator

grantfirl commented May 20, 2025 •
edited
Loading

@AnningCheng-NOAA If you want to look at the logs, etc., (on Hera) my test code is here: /scratch1/BMC/gmtb/Grant.Firl/ufs-weather-model-test/tests and the run directories are here: /scratch1/BMC/gmtb/Grant.Firl/stmp2/Grant.Firl/FV3_RT/rt_373056

I'm pretty confident that the problem is described in the previous comment though.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented May 20, 2025 via email

@grantfirl
Copy link
Collaborator

grantfirl commented May 22, 2025 •
edited
Loading

@AnningCheng-NOAA I pushed the test_changes.list and the RT log from Hera for all tests. In addition to the new test that you added, the other tests that set mraerosol to True are also changing results. Is this expected?

All other tests pass.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented May 22, 2025 via email

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented May 25, 2025 via email

@grantfirl
Copy link
Collaborator

@jkbk2004 This can go after the GFSv17 high priority PRs.

@grant
Copy link

grant commented May 28, 2025

Don't @ me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbk2004 jkbk2004 jkbk2004 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnningCheng-NOAA @grantfirl @jkbk2004 @BrianCurtis-NOAA @grant