-
Notifications
You must be signed in to change notification settings - Fork 268
Merge FV3 changes for water vapor photochemistry diagnostics #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Merge FV3 changes for water vapor photochemistry diagnostics #2707
Conversation
I worked out how to run the regression tests. How do I get more information from the failures than "this broke stuff"? |
Found the logs, and the results with more detail than the logs. There are changes to precipitation and radiation, mostly, |
Ya, I was going to suggest looking in tests/logs/RegressionTests_your_machine.log for a bit more info, then to look in the run directory at logs for individual tests. Looking at the your code changes, I would not expect any results to change unless the new diagnostics that you're adding are added to the output files, so it's somewhat surprising that you're seeing different results. |
@DWesl Are you sure that you've updated your PR branches to the latest develop branches? The fact that the PR says that there are conflicts that must be resolved makes me think that perhaps you're not testing with your changes on top of the latest code (which the RT results are based on). |
…-photochemistry-diagnostics
Just finished updating that, and re-running tests. The FV3 update looks like just my changes now, which is nice. |
and these directories have
the |
@DWesl I'm running the full rt.conf on Hera for this PR. If you add my user (@grantfirl) as a collaborator on your branch, I can push the logs. If not, I can paste them in a comment. |
I think I just added you as a collaborator on my fork. Is |
@DWesl Did you run it using ecflow?
|
I specified -a, but neither -e nor -r. I suppose that would do it. Should I look into adding a note to |
@DWesl Agree with @DeniseWorthen's response. I use
I do this within a |
@DWesl Also, there is no need for you to re-run the tests if mine complete successfully. |
Yeah, but there's a decent chance I'll wind up with a third PR at some point, and knowing how to run the tests will help with that
I'd likely do |
@DWesl I'm running into runtime failures for the following tests: There seems to be a division by zero which is caught when the debug compilation flags are being used. If you have access to Hera, my RT run directories are here: /scratch1/BMC/gmtb/Grant.Firl/stmp2/Grant.Firl/FV3_RT/rt_2254886 |
As mentioned on the other PR, I'm running regression tests on a variant that should avoid this. The run directory is |
It's telling me the |
Ah. Including my UPP updates for stratopause humidity in the tree will cause differences. I undid those changes and started the tests again. EDIT: then killed the old test process, since it'll note stratopause humidity changes in every test |
Four failures, all because the tests couldn't find the files to compare to.
The debug tests failed, indicating |
The four failures are $ bash <(grep -B5 -e 'NOT IDENTICAL' logs/log_hera/run_{control,rap}_diag_debug_{intel,gnu}.log | grep nccmp | cut -d+ -f2)
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13018e-13 2.30345e-12 2.91647e-12 4.50814e-14 1.88045e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13017e-13 2.30343e-12 2.91645e-12 4.50813e-14 1.88045e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210232 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54535e-14 1.88498e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92064e-12 4.5402e-14 1.88471e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210234 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54534e-14 1.88498e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92063e-12 4.5402e-14 1.88471e-13 I think this would be due to the inclusion of
|
And with the new changes, still two failed comparisons for each of four failed test cases: $ bash <(grep -B5 -e 'NOT IDENTICAL' logs/log_hera/run_{control,rap}_diag_debug_{intel,gnu}.log | grep nccmp | cut -d+ -f2)
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13018e-13 2.30345e-12 2.91647e-12 4.50814e-14 1.88045e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13017e-13 2.30343e-12 2.91645e-12 4.50813e-14 1.88045e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210232 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54535e-14 1.88498e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92064e-12 4.5402e-14 1.88471e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210234 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54534e-14 1.88498e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92063e-12 4.5402e-14 1.88471e-13 Still of order |
@DWesl Thanks for your testing. The result changes look reasonable given the code changes. Please mark the |
@DWesl There is no reason to create baselines on your part unless you suspect reproducibility issues (which you shouldn't for these changes). When a PR is marked that it changes baselines, the UFS code managers will create the new baselines during the merge process. |
Edited top comment to note change in baselines. |
…-photochemistry-diagnostics
…-photochemistry-diagnostics
$ bash <(grep -B5 -e 'NOT IDENTICAL' logs/log_hera/run_{control,rap}_diag_debug_{intel,gnu}.log | grep nccmp | cut -d+ -f2) Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13018e-13 2.30345e-12 2.91647e-12 4.50814e-14 1.88045e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13017e-13 2.30343e-12 2.91645e-12 4.50813e-14 1.88045e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210232 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54535e-14 1.88498e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92064e-12 4.5402e-14 1.88471e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210234 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54534e-14 1.88498e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92063e-12 4.5402e-14 1.88471e-13
…-photochemistry-diagnostics
In particular, allow the ozone scheme to have two extra sets of parameters during the ozone hole without crashing the model.
…hemistry-index-fix
With a separate index for each photochemistry scheme, we can move the index-finding calls in the conditional for the photochemistry scheme.
…hemistry-index-fix
…-photochemistry-diagnostics
@DWesl can you sync up branches? |
I thought I just did: the "merge status" widget at the end of the commit thread doesn't mention conflicting changes to |
Tests run with upstream updates. Changes still small: $ bash <(grep -B5 -e 'NOT IDENTICAL' logs/log_hera/run_{control,rap}_diag_debug_{intel,gnu}.log | grep nccmp | cut -d+ -f2)
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13018e-13 2.30345e-12 2.91647e-12 4.50814e-14 1.88045e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13017e-13 2.30343e-12 2.91645e-12 4.50813e-14 1.88045e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210232 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54535e-14 1.88498e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92064e-12 4.5402e-14 1.88471e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210234 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54534e-14 1.88498e-13
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92063e-12 4.5402e-14 1.88471e-13 |
…dition. That was ufs-community/ccpp-physics#286 and NOAA-EMC/fv3atm#971, with corresponding PR ufs-community#2750 here.
Mismatches: Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13018e-13 2.30345e-12 2.91647e-12 4.50814e-14 1.88045e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45142e-07 1.84607e-07 -6.10962e-13 2.31178e-12 2.92274e-12 4.52122e-14 1.88223e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.44722e-07 1.8447e-07 -6.13017e-13 2.30343e-12 2.91645e-12 4.50813e-14 1.88045e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210232 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54535e-14 1.88498e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92064e-12 4.5402e-14 1.88471e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210234 1.45916e-07 1.84811e-07 -6.12138e-13 2.31538e-12 2.92752e-12 4.54534e-14 1.88498e-13 Variable Group Count Sum AbsSum Min Max Range Mean StdDev dtend_qv_phys / 3210240 1.45751e-07 1.84795e-07 -6.14611e-13 2.30602e-12 2.92063e-12 4.5402e-14 1.88471e-13
Commit Queue Requirements:
Description:
Add water vapor photochemistry diagnostics, with changes in FV3 and CCPP-physics to support this and add the results to
dtend_qv_phys
.Add parameters to water vapor photochemistry scheme to return the terms of the water vapor photochemistry scheme, then stick the descriptions in the metadata files next to the ozone photochemistry diagnostics, and add the variable declarations to allocate storage for the diagnostics.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: