V15 QA acceptance tests with appsettings #19550
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests-with-appsettings # Conflicts: # build/nightly-E2E-test-pipelines.yml
…tests-with-appsettings
…tests-with-appsettings
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the acceptance test suite by introducing configurable appsettings and corresponding test classes for different scenarios (default, unattended install, and Delivery API), and updates the CI pipeline to run these variants.
- Added
appsettings.jsonconfigurations for Default, UnattendedInstallConfig, and DeliveryApi test scenarios - Introduced Playwright spec files for SQLite, SQL Server Express installs, and Delivery API validations
- Updated
playwright.config.tsand the nightly E2E pipeline to parameterize tests by configuration
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/.../UnattendedInstallConfig/appsettings.json | New config disabling unattended install and cleanup for install tests |
| tests/.../UnattendedInstallConfig/Install/InstallSQLite.spec.ts | New Playwright test for SQLite install |
| tests/.../UnattendedInstallConfig/Install/InstallSQLServer.spec.ts | New Playwright test for SQL Server Express install |
| tests/.../DeliveryApi/appsettings.json | New Delivery API test configuration |
| tests/.../DeliveryApi/Program.cs | Program setup for Delivery API integration test |
| tests/.../DeliveryApi/DeliveryApi.spec.ts | New Playwright tests against Delivery API |
| tests/.../DefaultConfig/appsettings.json | Default test configuration |
| tests/.../playwright.config.ts | Added defaultConfig, deliveryApi, and unattendedInstallConfig projects |
| tests/.../package.json | Bumped testhelpers dependency |
| build/nightly-E2E-test-pipelines.yml | Extended pipeline to handle multiple testFolder matrices |
Files not reviewed (1)
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
build/nightly-E2E-test-pipelines.yml:301
- The
DefaultConfigmatrix is usingnpm run testSqlite, which only runs the SQLite install tests—this should likely benpm run testto execute the full default suite.
testCommand: "npm run testSqlite -- --shard=1/3"
tests/Umbraco.Tests.AcceptanceTest/tests/DeliveryApi/Program.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/DeliveryApi/DeliveryApi.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to run tests with different app settings and classes.
This PR contains tests without unattended install and a few tests using the Delivery Api