Fix readonly UI for create document user permission #19554
+33
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
added
release/16.1.0
status/regression
category/ux
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how create/update permissions are enforced by removing individual flags, introducing unified handlers, and reacting to the document's isNew state.
- Replaced
#userCanCreate/#userCanUpdateflags with#enforceUserPermissionmethod - Added
#handleUserPermissionChangeto centralize read-only guard logic - Observes
isNewto decide whether to apply create or update permission rules
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts:192
- Add a JSDoc comment for
#enforceUserPermission(and similarly for#handleUserPermissionChange) to explain its purpose, parameters, and side-effects on the read-only guard.
#enforceUserPermission(verb: string, message: string) {
...braco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts
Outdated
Show resolved
Hide resolved
...braco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts
Outdated
Show resolved
Hide resolved
…kspace/document-workspace.context.ts Co-authored-by: Copilot <[email protected]>
…//github.com/umbraco/Umbraco-CMS into v16/bugfix/create-update-permission-readonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19286
Please ensure that the following user permission combinations work as expected: