Skip to content

fix(build): finalize pipeline #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

fix(build): finalize pipeline #164

merged 3 commits into from
Apr 29, 2025

Conversation

vinayraghu
Copy link
Collaborator

Host of minor issues cropped up since the last time we ran the build

  • A recent PR introduced some breaking changes
  • We needed to run apt-get update before installing packages for ubuntu to succeed
  • Location of notarize js was wrong somehow
  • optionalDependencies were not getting installed unless explicitly stated in pacakge.json

This PR fixes the build

CleanShot 2025-04-28 at 20 55 37@2x

@vinayraghu vinayraghu merged commit 8506db8 into main Apr 29, 2025
3 checks passed
@rupertsworld rupertsworld deleted the fix-release-pipeline branch April 29, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vinayraghu