List2need add list options #1416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for all needs in the list
for more information, see https://pre-commit.ci
|
Thanks @christopheseyler, this is definitely better, but bear with me a little on this as I want to have a bit more of a thought on it |
|
Hi, Do not worry, take your time. Just note that I still kept the :tags: option al list2need level, even if it could also be included in the :list-options: as well. I think that the tags is so "common" for the needs (used for filter) that having its own "option" is a better choice than buried it in the list-options. (I hope you understand what i mean ;) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseed the PR #1345
This feature allows to set common options to all needs in a list defined by list2need directive.
Comparing to the PR #1345, I implemented a new list-options option with the ability to nest all options that will be common
(I removed the hide specific option as it can easily be added in this new list-options
I left a regex matching on the list-options value allowing to aggregate options that could be defined in one list item through the meta-data feature.