Media handling improvements + fixed logging #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced `_fetch` method to support saving response directly to a file. - Updated `add_video` method to streamline video processing and handle media source IDs. - Improved error handling and logging throughout video and image processing methods. - Added parallel processing for handling multiple videos.
|
@valentinfrlch can i get a PR review pls? |
|
Very busy this and next week, but I'll review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved
video_analyzermedia handlingAdded URL support to for
video_path- includingmedia-source://and relative/api/frigate/...paths.Parallel video processing to avoid huge delays when processing multiple files.
Replaced
os.system()withasyncio.create_subprocess_shell()and added extensive debug logging around FFmpegasyncio.create_subprocess_execto avoid security issues, but it comes with a problem of locatingffmpegbinary, because it needs a full path to executable.Fixed
video_pathescaping usingshlex.quote-f"'{video_path}'"could be broken too easily (Doorbell's video.mp4)Refactoring file fetching (
_fetchmethod) to write files using streaming.Debug logging fixes