Skip to content

feat(xo-6/pool): add system page #8581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

feat(xo-6/pool): add system page #8581

wants to merge 28 commits into from

Conversation

UnelDev
Copy link
Member

@UnelDev UnelDev commented May 15, 2025

Description

Creating system pages for VM
Creating multiple cards: PoolConnections, PoolGeneralInfo, PoolLicensing, PoolManagement, PoolNetworking, PoolResourceManagent, PoolStorageConfigration for show data.
Create store and type for server.

screenshots

image
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@UnelDev UnelDev self-assigned this May 15, 2025
@UnelDev UnelDev marked this pull request as ready for review May 15, 2025 07:53
@UnelDev UnelDev marked this pull request as draft May 15, 2025 08:55
@UnelDev UnelDev force-pushed the xo-6/pool-system branch from d423faf to 4444d86 Compare May 15, 2025 09:11
@UnelDev UnelDev marked this pull request as ready for review May 15, 2025 12:28
@UnelDev UnelDev requested a review from J0ris-K May 15, 2025 12:28
const vmServerByPoolMap = new Map<XoPool['id'], XoServer[]>()

baseContext.records.value.forEach(server => {
const poolId = server.poolId
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server.poolId can be undefined

@J0ris-K J0ris-K requested a review from OlivierFL May 21, 2025 11:18
@OlivierFL OlivierFL changed the title feat(xo-6) add system page for pool feat(xo-6/pool): add system page May 28, 2025
@UnelDev UnelDev force-pushed the xo-6/pool-system branch 4 times, most recently from 2c64ea8 to e4ecd5b Compare May 28, 2025 14:30
@UnelDev UnelDev force-pushed the xo-6/pool-system branch from e4ecd5b to 3756c91 Compare May 28, 2025 14:49
@OlivierFL OlivierFL requested a review from J0ris-K May 28, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants