refactor(scheme): prevent duplicate registration in RegisterSchemas

[googs1025]

Pull Request Description

[Please provide a clear and concise description of your changes here]

• prevent duplicate registration of orchestrationv1alpha1.AddToScheme

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @googs1025, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the RegisterSchemas function in cmd/controllers/main.go to improve code organization and prevent redundant schema registrations. It centralizes feature flag checks by assigning their results to local variables and consolidates the orchestrationv1alpha1.AddToScheme call to ensure it's only executed once, even if multiple related features are enabled.

Highlights

• Centralized Feature Flag Checks: Introduced local boolean variables (e.g., podAutoscalerEnabled, modelAdapterEnabled) to store the results of features.IsControllerEnabled calls, making the conditional logic clearer and potentially more efficient by avoiding repeated function calls.
• Prevented Duplicate Schema Registration: Consolidated the orchestrationv1alpha1.AddToScheme call into a single if statement (if distributedInferenceEnabled || kvCacheEnabled || stormServiceEnabled), ensuring that this specific schema is added only once, even if multiple controllers that depend on it are enabled.
• Code Formatting Improvement: The scheme.AddUnversionedTypes call was reformatted to span multiple lines, enhancing readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the RegisterSchemas function to centralize feature flag checks and prevent duplicate schema registrations. The changes improve code readability and fix a potential bug with duplicate registrations of orchestrationv1alpha1. My main feedback is to remove a redundant call to scheme.AddUnversionedTypes which is already present in the init function.

[Jeffwan]

do you know whether there's a way fine grain control the scheme. Currently, we have to register the group level.

[googs1025]

I don't quite understand. Do you mean whether can we more finely control which CRDs are registered to the scheme?

[googs1025]

IIUC, Kubernetes runtime.Scheme now registers types at the API group level (e.g., orchestrationv1alpha1), and not to register individual CRDs selectively. 🤔

However, it is technically possible to achieve finer control by manually registering specific types using scheme.AddKnownTypes()(maybe..but not test this at all), also this increases maintenance cost.

[Jeffwan]

sure. let's keep group level at this moment