[0.9.1][Dist][Bugfix] Fix mc2 process group to resolve self.cpu_group is None #1831
+9
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MengqingCao <[email protected]>
|
Offline scenario verification passed！tks! |
zzzzwwjj
approved these changes
Jul 17, 2025
wangxiyuan
changed the title
zzzzwwjj
approved these changes
Jul 18, 2025
Yikun
reviewed
Jul 20, 2025
Yikun
changed the title
This was referenced Jul 20, 2025
Dose this externel dp means build the process group outside the vllm? |
|
Yes, all the ranks of vllm instances in external luanch mode should be included in the process group.
…---- Replied Message ----
| From | ***@***.***> |
| Date | 07/20/2025 10:27 |
| To | ***@***.***> |
| Cc | Mengqing ***@***.***>***@***.***> |
| Subject | Re: [vllm-project/vllm-ascend] [0.9.1][Dist][Bugfix] Fix mc2 process group to resolve self.cpu_group is None (PR #1831) |
ganyi1996ppo left a comment (vllm-project/vllm-ascend#1831)
What this PR does / why we need it?
This pr fixes the bug, which throw an error self.cpu_group is None. This is mainly caused by the wrong group ranks of process groups maintained in vllm-ascend. We need to take external dp size into account to ensure it work fine with external_launch mode.
Related fixes: #1396#1154
Dose this externel dp means build the process group outside the vllm?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
ganyi1996ppo
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This pr fixes the bug, which throw an error
self.cpu_group is None. This is mainly caused by the wrong group ranks of process groups maintained in vllm-ascend. We need to take external dp size into account to ensure it work fine withexternal_launchmode.Related fixes: #1396 #1154