-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[WIP][RC] Update PyTorch to 2.8.0 #20358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @huydhn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request initiates the process of upgrading the project's PyTorch dependency to version 2.8.0, targeting its release candidate builds. This involves updating not only the core PyTorch version but also ensuring compatibility across related libraries like Torchaudio and Torchvision, and adjusting build and test environments to source these new versions from PyTorch's test indices. The changes are foundational, impacting various dependency management files and build configurations.
Highlights
- PyTorch Version Update: The core PyTorch dependency has been updated from version 2.7.0 to 2.8.0 across
pyproject.toml
,requirements/build.txt
,requirements/cpu.txt
,requirements/cuda.txt
,requirements/rocm-build.txt
, andrequirements/test.in
. - Associated Library Updates: Torchaudio and Torchvision have been updated to their 2.8.0 and 0.23.0 compatible versions, respectively, to align with the new PyTorch release.
- Test Index Configuration: Build and test configurations, including
.pre-commit-config.yaml
,docker/Dockerfile
, and variousrequirements/*.txt
files, have been adjusted to pull PyTorch and related packages from thetest
release candidate index URLs (e.g.,https://download.pytorch.org/whl/test/cu128
). - CUDA and ROCm Dependency Alignment: Specific CUDA-related dependencies in
requirements/test.txt
(e.g.,nvidia-cublas
,nvidia-cudnn
) have been updated to align with the PyTorch 2.8.0 release candidate, and ROCm versions inrequirements/rocm-build.txt
are updated to 6.3. - FlashInfer and Triton Updates: The FlashInfer wheel URL in
docker/Dockerfile
has been updated to reflect PyTorch 2.8, and the Triton version inrequirements/test.txt
has been bumped from 3.3.0 to 3.4.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates PyTorch to version 2.8.0 and its related dependencies like torchvision, torchaudio, and Triton. The changes are mostly version bumps in requirement files and configuration files to use the PyTorch test package index. The changes look consistent with the goal of the PR. I've found one minor issue related to redundant configuration that could be improved for better maintainability.
@@ -49,7 +49,7 @@ repos: | |||
rev: 0.6.17 | |||
hooks: | |||
- id: pip-compile | |||
args: [requirements/test.in, -o, requirements/test.txt, --index-strategy, unsafe-best-match, --torch-backend, cu128] | |||
args: [requirements/test.in, -o, requirements/test.txt, --index-strategy, unsafe-best-match, --extra-index-url, https://download.pytorch.org/whl/test/cu128] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a redundancy in how the extra index URL for PyTorch is specified.
The --extra-index-url
is provided here in the pip-compile
arguments, but it has also been added to requirements/test.in
.
The comment in the generated requirements/test.txt
file indicates that the intended command for regeneration is uv pip compile requirements/test.in ...
without the --extra-index-url
argument, implying it should be read from the .in
file.
To maintain a single source of truth and avoid confusion, it would be best to remove the --extra-index-url
argument from this hook and rely on the definition in requirements/test.in
. This would make the pre-commit hook's behavior consistent with the documented generation command.
args: [requirements/test.in, -o, requirements/test.txt, --index-strategy, unsafe-best-match]
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
This is a test PR to update PyTorch version to 2.8.0 release candidates