Skip to content

[Model] Add Ling implementation #20482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Conversation

ant-yy
Copy link
Contributor

@ant-yy ant-yy commented Jul 4, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results

Purpose

Add [Model] Ling implementation

This PR adds support for the Ling Mixture-of-Experts (MoE) language model series open-sourced by InclusionAI (GitHub). The implementation includes:

  • Ling-lite: 16.8B total parameters (2.75B activated)
  • Ling-plus: 290B total parameters (28.8B activated)

Key features:

  1. Scalable MoE architecture enabling flexible parameter allocation
  2. State-of-the-art performance across NLP benchmarks
  3. Task-adaptive structure for diverse applications
  4. Apache 2.0 licensed open-source implementation

The implementation follows vLLM's model integration patterns and maintains compatibility with existing serving infrastructure. This addition will allow vLLM users to leverage Ling's efficient inference capabilities while benefiting from the framework's high-throughput serving optimizations.

Ling

Test Plan

We will conduct the following datasets tests in subsequent phases, and the results will be supplemented accordingly:
Datasets to be evaluated: MMLU(EM), GPQA(Pass@1), HumanEval(Pass@1), LiveCodeBench 2408-2502 (Pass@1), LCBench(pass@1), Math(EM), AIME2024(pass@1), OlympiadBench(pass@1), BBH(EM), IFEval(Prompt Strict), BFCL_live1.

Test Result

Here are the results based on vLLM 0.7.3.

Signed-off-by: vito.yy <[email protected]>
Copy link

github-actions bot commented Jul 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ant-yy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for the Ling Mixture-of-Experts (MoE) language model series within the vLLM framework. It enables efficient inference for Ling-lite and Ling-plus models by integrating their specific architecture, including attention, MLP, and MoE layers, while leveraging vLLM's high-throughput serving optimizations. The changes involve adding new model definition files, registering the model, and defining its configuration parameters.

Highlights

  • New Model Integration: Added full support for the Ling Mixture-of-Experts (MoE) language model series, including Ling-lite and Ling-plus variants, enabling their efficient inference within vLLM.
  • MoE Architecture Implementation: Implemented the specific MoE architecture of Ling models, featuring BailingAttention, BailingMLP, and a BailingMoE layer with support for shared experts and FusedMoE.
  • vLLM Framework Integration: Integrated the Ling model into vLLM's serving infrastructure, including support for LoRA, quantization, and pipeline parallelism, ensuring compatibility with existing vLLM features.
  • Configuration Definition: Defined a new BailingMoeConfig class to specify the architectural parameters and default values for Ling MoE models, allowing vLLM to correctly load and configure them.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Ling (Bailing) Mixture-of-Experts model. The implementation looks solid and follows the existing patterns in vLLM. I've identified a few areas for improvement, mainly related to code cleanliness and consistency, such as removing unused imports, correcting LoRA configurations, and maintaining alphabetical order in registries and import statements. Addressing these points will enhance the maintainability of the new code.

@jeejeelee jeejeelee changed the title Add [Model] Ling implementation [Model] Add Ling implementation Jul 4, 2025
@jeejeelee jeejeelee added the new-model Requests to new models label Jul 4, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 9, 2025
Signed-off-by: vito.yy <[email protected]>
Copy link

mergify bot commented Jul 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ant-yy.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 9, 2025
@ant-yy
Copy link
Contributor Author

ant-yy commented Jul 9, 2025

Due to an accidental Git operation, this pull request was mistakenly closed. A new PR will be resubmitted to add the Ling Model, and this existing PR is hereby marked as obsolete.

@ant-yy
Copy link
Contributor Author

ant-yy commented Jul 9, 2025

new pr: #20680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation frontend needs-rebase new-model Requests to new models tool-calling v1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants