Skip to content

[Doc] Add engine args back in to the docs #20674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 10, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Jul 9, 2025

Changes to vLLM:

  • Adds requirements necessary to import FlexibleArgumentParser, EngineArgs and AsyncEngineArgs without fully installing vLLM
  • Update some imports to be more defensive:
    • Only import for type checking if the class is only used for type hints
    • Delay third party imports when the engine args needs something from a submodule that doesn't require the import

Changes to docs:

  • New hook to generate argparse pages in docs/argparse
  • New override to enable toc_depth in frontmatter:
    • Allows us to specify generated arguments as headings without polluting the TOC
    • Allows users to link to specific arguments, this was not possible in the Sphinx version of this doc
  • Update docs/configuration/engine_args.md to use the generated docs

Follow up:

Fixes #18707
FIX #20444

@hmellor hmellor requested a review from aarnphm as a code owner July 9, 2025 10:10
@mergify mergify bot added documentation Improvements or additions to documentation ci/build deepseek Related to DeepSeek models qwen Related to Qwen models labels Jul 9, 2025
Copy link

mergify bot commented Jul 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 9, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hmellor, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the documentation for vLLM, particularly around engine arguments. It introduces a new system for automatically generating documentation from argparse configurations, and it also makes some changes to the vLLM codebase to support this new documentation system and to clean up some deprecated features.

Highlights

  • Documentation: Adds a new hook to generate argparse pages in docs/argparse, automating the documentation of command-line arguments.
  • Documentation: Introduces a new override to enable toc_depth in frontmatter, allowing specification of generated arguments as headings without polluting the table of contents and enabling linking to specific arguments.
  • vLLM Changes: Adds requirements necessary to import FlexibleArgumentParser, EngineArgs and AsyncEngineArgs without fully installing vLLM.
  • vLLM Changes: Updates imports to be more defensive by only importing for type checking if the class is only used for type hints and delaying third-party imports when the engine args needs something from a submodule that doesn't require the import.
  • vLLM Changes: Stops using StoreBoolean in tests, as it's not used by any parsers, paving the way for its complete removal.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automatic generation of documentation for engine arguments, enhancing code quality and maintainability through defensive imports and a well-structured documentation generation script.

@mergify mergify bot removed the needs-rebase label Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Harry Mellor <[email protected]>
@hmellor
Copy link
Member Author

hmellor commented Jul 9, 2025

Docs build is failing because of some missing mocking (my developement environment didn't have vLLM installed, but it had been installed before so some files which are only generated on install were present).

I'll look into fixing it soon.

@hmellor
Copy link
Member Author

hmellor commented Jul 9, 2025

@mergify mergify bot added the frontend label Jul 9, 2025
@mergify mergify bot added the new-model Requests to new models label Jul 10, 2025
Additionally, list elements can be passed individually using '+':
- `--json-arg '{"key4": ["value3", "value4", "value5"]}'`\n
- `--json-arg.key4+ value3 --json-arg.key4+='value4,value5'`\n\n"""
json_tip = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For triple backtick-formatted strings, the subsequent lines should not be indented at all

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the Server Arguments doc

@hmellor
Copy link
Member Author

hmellor commented Jul 10, 2025

We should also update the Server Arguments doc

This is listed as a follow up task in the PR description, it depends on another PR that cleans up the server CLI

Signed-off-by: Harry Mellor <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for working on this!

@vllm-bot vllm-bot merged commit 3482fd7 into vllm-project:main Jul 10, 2025
7 of 9 checks passed
@hmellor hmellor deleted the mkdocs-argparse branch July 10, 2025 15:31
Chen-zexi pushed a commit to Chen-zexi/vllm that referenced this pull request Jul 13, 2025
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Jul 15, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build deepseek Related to DeepSeek models documentation Improvements or additions to documentation frontend new-model Requests to new models qwen Related to Qwen models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Usage]: 新版文档太难使用了 [Doc]: Newest documentation for engine arguments is significantly worse than v0.8.5 and prior
3 participants