-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
[Doc] Add engine args back in to the docs #20674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hmellor, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the documentation for vLLM, particularly around engine arguments. It introduces a new system for automatically generating documentation from argparse configurations, and it also makes some changes to the vLLM codebase to support this new documentation system and to clean up some deprecated features.
Highlights
- Documentation: Adds a new hook to generate argparse pages in
docs/argparse
, automating the documentation of command-line arguments. - Documentation: Introduces a new override to enable
toc_depth
in frontmatter, allowing specification of generated arguments as headings without polluting the table of contents and enabling linking to specific arguments. - vLLM Changes: Adds requirements necessary to import
FlexibleArgumentParser
,EngineArgs
andAsyncEngineArgs
without fully installing vLLM. - vLLM Changes: Updates imports to be more defensive by only importing for type checking if the class is only used for type hints and delaying third-party imports when the engine args needs something from a submodule that doesn't require the import.
- vLLM Changes: Stops using
StoreBoolean
in tests, as it's not used by any parsers, paving the way for its complete removal.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces automatic generation of documentation for engine arguments, enhancing code quality and maintainability through defensive imports and a well-structured documentation generation script.
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Harry Mellor <[email protected]>
Docs build is failing because of some missing mocking (my developement environment didn't have vLLM installed, but it had been installed before so some files which are only generated on install were present). I'll look into fixing it soon. |
Signed-off-by: Harry Mellor <[email protected]>
…nstructable Signed-off-by: Harry Mellor <[email protected]>
Preview: https://vllm--20674.org.readthedocs.build/en/20674/configuration/engine_args.html Build time: 6m42 (🎉) |
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
vllm/engine/arg_utils.py
Outdated
Additionally, list elements can be passed individually using '+': | ||
- `--json-arg '{"key4": ["value3", "value4", "value5"]}'`\n | ||
- `--json-arg.key4+ value3 --json-arg.key4+='value4,value5'`\n\n""" | ||
json_tip = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For triple backtick-formatted strings, the subsequent lines should not be indented at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the Server Arguments doc
This is listed as a follow up task in the PR description, it depends on another PR that cleans up the server CLI |
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for working on this!
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Patrick von Platen <[email protected]>
Changes to vLLM:
FlexibleArgumentParser
,EngineArgs
andAsyncEngineArgs
without fully installing vLLMChanges to docs:
docs/argparse
toc_depth
in frontmatter:docs/configuration/engine_args.md
to use the generated docsFollow up:
Fixes #18707
FIX #20444