-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Refactor] Remove Unused Naive Moe Kernels #21125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yewentao256 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a refactoring effort to remove unused "naive" Mixture-of-Experts (MoE) kernels. The changes are clean and involve the deletion of C++ kernels, Python wrappers, benchmarks, and tests related to the old moe_permute
and moe_unpermute
operations. This cleanup improves the maintainability of the codebase. The changes appear to be correct and self-contained. I have reviewed the removals and found no issues.
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: yewentao256 <[email protected]>
Seems stagnant, could you take a look? Thanks! @WoosukKwon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're going to integrate them here https://github.com/vllm-project/vllm/pull/17934/files
@tlrmchlsmth Thanks for letting me know. |
Hi @yewentao256 - I believe there is value is having the cuda permute/unpermute kernels. I experimented with both the triton kernels (introduced in #20903) and the cuda kernels (#20982) - and decided to merge the triton kernels due to slightly better TTFT.
The goal is to have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varun-sundar-rabindranath
Make sense, thanks for letting me know the context!
Close this pr as not needed |
Purpose
Fixed #21124