-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Attention] Clean up iRoPE in V1 #21188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Attention] Clean up iRoPE in V1 #21188
Conversation
Signed-off-by: Lucas Wilkinson <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors the handling of iRoPE by centralizing the logic and removing it from individual V1 attention backends. The changes are clean and align with the stated goal. I've identified one potential issue regarding a removed warning for the CPU backend that could lead to silent correctness issues if iRoPE is not actually supported. Please see the detailed comment.
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll share it with @yaochengji to make sure TPU is unaffected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! This change looks good on TPU.
This pull request has merge conflicts that must be resolved before it can be |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Lucas Wilkinson <[email protected]> Co-authored-by: Michael Goin <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
With 89cab4d we can actually entirely remove the concept of iRoPE from V1 backends.
Test Plan
lm eval checks; maybe someone with access to a TPU could help me test that? otherwise the change seems simple enough
Test Result
(Optional) Documentation Update