-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
[Model][CI] Let more pooling models support v1 #21747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wang.yuqi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to expand V1 support to more pooling models by removing V1-specific skips and workarounds in the tests and updating model implementations. The changes look good and are consistent with the goal.
I've found one potential issue: ModernBertForSequenceClassification
is still marked as V0-only, while the tests are being updated to run it on V1. This will likely lead to test failures. Please see my detailed comment.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this PR first. Will keep investigating ModernBert CUDA graph issue.
I think the API server failure is related to pooling model memory usage somehow... |
We are currently testing precompiled wheels in CI, maybe it's not working properly |
Signed-off-by: wang.yuqi <[email protected]>
Merging main into this pr will cause the tests to fail. (╯‵□′)╯︵┻━┻ |
LGTM now |
Actually wait, let me unblock pooling tests |
Let's just merge this PR then. It seems the tests pass |
Please comment on that PR |
Is it possible that some commit in main is conflicting with this PR? |
Let's see if the CI passes after merge |
anyhow, this is best I can do, Other issues are too complex for me, let's solve them in other PRs. |
Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: jingyu <[email protected]>
Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
#21270 Let v1 support encoder-only models, theoretically all pooling models should support v1.
Let's check which models are not supported.
fixed
address #21470 (comment)
cc @maxdebayser @DarkLight1337
Test Plan
Test Result
(Optional) Documentation Update