Skip to content

[Model][CI] Let more pooling models support v1 #21747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2025

Conversation

noooop
Copy link
Contributor

@noooop noooop commented Jul 28, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

#21270 Let v1 support encoder-only models, theoretically all pooling models should support v1.

Let's check which models are not supported.

fixed

  • fix GteNewModel
  • fix JinaRobertaModel
  • fix ModernBertModel
  • fix NomicBertModel
  • float32 is supported by V1
  • Alibaba-NLP/gte-Qwen2-1.5B-instruct is supported by V1

address #21470 (comment)

cc @maxdebayser @DarkLight1337

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: wang.yuqi <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to expand V1 support to more pooling models by removing V1-specific skips and workarounds in the tests and updating model implementations. The changes look good and are consistent with the goal.

I've found one potential issue: ModernBertForSequenceClassification is still marked as V0-only, while the tests are being updated to run it on V1. This will likely lead to test failures. Please see my detailed comment.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

noooop added 3 commits July 28, 2025 20:15
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
@noooop noooop marked this pull request as ready for review July 29, 2025 02:43
@mergify mergify bot added the qwen Related to Qwen models label Jul 29, 2025
@noooop noooop changed the title [Model][CI] Have as many pooling models as possible support v1 [Model][CI] Let more pooling models support v1 Jul 29, 2025
@noooop
Copy link
Contributor Author

noooop commented Jul 29, 2025

@DarkLight1337

Ready for review

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 29, 2025
@noooop noooop marked this pull request as draft July 29, 2025 11:09
@noooop noooop marked this pull request as ready for review July 29, 2025 15:33
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this PR first. Will keep investigating ModernBert CUDA graph issue.

@DarkLight1337
Copy link
Member

I think the API server failure is related to pooling model memory usage somehow...

@DarkLight1337
Copy link
Member

We are currently testing precompiled wheels in CI, maybe it's not working properly

Signed-off-by: wang.yuqi <[email protected]>
@noooop
Copy link
Contributor Author

noooop commented Jul 31, 2025

Merging main into this pr will cause the tests to fail.

@DarkLight1337 @Isotr0py

(╯‵□′)╯︵┻━┻

@noooop noooop changed the title [Do not Merge] This pr might have triggered a CI bug [Model][CI] Let more pooling models support v1 Jul 31, 2025
@DarkLight1337
Copy link
Member

LGTM now

@DarkLight1337
Copy link
Member

Actually wait, let me unblock pooling tests

@noooop
Copy link
Contributor Author

noooop commented Jul 31, 2025

@DarkLight1337

Compare this PR with #21929,

Merging main into this pr will cause the tests to fail.

#21964 did not solve this problem

@DarkLight1337
Copy link
Member

Let's just merge this PR then. It seems the tests pass

@DarkLight1337
Copy link
Member

#21964 did not solve this problem

Please comment on that PR

@vllm-bot vllm-bot merged commit 2836dd7 into vllm-project:main Jul 31, 2025
69 of 71 checks passed
@noooop
Copy link
Contributor Author

noooop commented Jul 31, 2025

@DarkLight1337

Is it possible that some commit in main is conflicting with this PR?

@DarkLight1337
Copy link
Member

Let's see if the CI passes after merge

@noooop
Copy link
Contributor Author

noooop commented Jul 31, 2025

anyhow, this is best I can do,

Other issues are too complex for me, let's solve them in other PRs.

@noooop noooop deleted the pooling_v1 branch July 31, 2025 11:57
@noooop noooop restored the pooling_v1 branch July 31, 2025 12:05
wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 5, 2025
@noooop noooop deleted the pooling_v1 branch August 5, 2025 11:36
vadiklyutiy pushed a commit to CentML/vllm that referenced this pull request Aug 5, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jingyu-ml pushed a commit to jingyu-ml/vllm that referenced this pull request Aug 8, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants