Skip to content

Migrate errors to use problem details #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: gh-pages
Choose a base branch
from
Open

Migrate errors to use problem details #146

wants to merge 9 commits into from

Conversation

wip-abramson
Copy link
Contributor

@wip-abramson wip-abramson commented Apr 24, 2025 •
edited by pr-preview bot
Loading

This issue addresses #87.

It also includes the error from #136. And pending a decision I will add the error in #140.

I also have a few questions about the errors.

  1. INVALID_VERIFICATION_METHOD and INVALID_RELATIONSHIP_FOR_VERIFICATION_METHOD are defined in the CID spec. I don't need to list them in this spec again right?
  2. All the errors related to public keys feel kind of strange and perhaps an artifact from when we used publicKey instead of verificationMethod and when we had many different types instead of Multikey. It feels like most of those errors are things the client would learn after resolving/dereferencing. Not something the resolution process is going to check.

@peacekeeper be great to get your thoughts.

Preview | Diff

@wip-abramson wip-abramson mentioned this pull request Apr 28, 2025
Open
@wip-abramson wip-abramson changed the title WIP - Migrate errors to use problem details Migrate errors to use problem details Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacekeeper peacekeeper Awaiting requested review from peacekeeper peacekeeper is a code owner

@dmitrizagidulin dmitrizagidulin Awaiting requested review from dmitrizagidulin dmitrizagidulin is a code owner

@mccown mccown Awaiting requested review from mccown mccown is a code owner

@ChristopherA ChristopherA Awaiting requested review from ChristopherA ChristopherA is a code owner

@danpape danpape Awaiting requested review from danpape danpape is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wip-abramson