[WOOMOB-961] Remove unused libsapachehttpclientandroid dependency

[malinajirka]

Fixes WOOMOB-961

Description

This PR removes the unused libs.apache.http.client.android dependency from the project. The dependency was identified as no longer needed and removing it helps reduce the app size and potential security surface area.

Testing information

Green CI should be enough.

The tests that have been performed

I ran ./gradlew :WooCommerce:assembleWasabiDebugAndroidTest to verify the dependency truly wasn't used.

Images/gif

Not applicable for dependency removal.

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	3c684ad
	Direct Download	woocommerce-wear-prototype-build-pr14422-3c684ad.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	3c684ad
	Direct Download	woocommerce-prototype-build-pr14422-3c684ad.apk

[samiuelson]

LGTM! Thanks.

[samiuelson]

Hm, actually it looks like the libs.apache.http.client.android dependency is needed for UI tests.

[malinajirka]

Interesting, I tried to build the UI tests but it's likely using reflection or something like that. @ParaskP7 is there a way how to mark the dependency as "used" in the dependency dashboard?

[ParaskP7]

👋 @malinajirka !

Interesting, I tried to build the UI tests but it's likely using reflection or something like that. @ParaskP7 is there a way how to mark the dependency as "used" in the dependency dashboard?

Do you mean something like that?

dependencyAnalysis {
    issues {
        onUnusedDependencies {
            // This dependency is actually needed otherwise the app will crash with a runtime exception.
            exclude(libs.eventbus.android.get().module.toString())
        }
    }
}

[malinajirka]

Nice, that's exactly what I mean - thank you 🙇 !

[malinajirka]

@samiuelson Good catch, I've reverted the removal and suppressed the unused warning.

[samiuelson]

LGTM. Thanks!