[POS as Tab i2] Show labels in navigation menu on tablets #14429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14429 +/- ##
============================================
- Coverage 37.92% 37.92% -0.01%
+ Complexity 9176 9175 -1
============================================
Files 1988 1988
Lines 112242 112242
Branches 14797 14797
============================================
- Hits 42567 42564 -3
- Misses 65799 65801 +2
- Partials 3876 3877 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
malinajirka
deleted the
wooprd-695-pos-as-a-tab-i2-show-labels-under-bottom-naviagation-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOPRD-695
Description
This PR addresses UI feedback from POS as tab i2 Call for testing: pdfdoF-7FH-p2#comment-8892
App's bottom navigation menu has labels shown under menu items on tablets. On phones UI remains unchanged.
Steps to reproduce
N/A
Testing information
Verify app's bottom menu with Compact/Medium/Large window size classes.
The tests that have been performed
Tested Compact/Medium/Large window size classes. See the results below.
Images/gif
Compact
Medium
Large
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.