Create a centralized service for a path to the main plugin file (4970) #3505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narek13
changed the title
Narek13
changed the title
AlexP11223
reviewed
Jul 4, 2025
AlexP11223
approved these changes
Jul 7, 2025
…ilures-in-module-service-files # Conflicts: # composer.lock
InpsydeNiklas
deleted the
PCP-4970-add-defensive-code-for-realpath-failures-in-module-service-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
The codebase has multiple service files that use
realpath(__FILE__)without proper error handling, which can cause fatalTypeErrorexceptions when the file path cannot be resolved. This issue was identified in production whererealpath()returnedfalse, causingdirname()to receive a boolean instead of a string.PR Description
This PR adds a centralized service for a path to the main plugin file with a fallback to use the
__FILE__whenrealpath()fails