Remove redundant authorize call in subscription renewal handler (1575) #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vaulted subscription renewal handler was attempting to authorize orders when the intent was set to "AUTHORIZE". This resulted in
ORDER_ALREADY_AUTHORIZEDerrors because PayPal orders created with tokens as a payment source are authorized automatically, with the authorization returned in the order creation response.This PR removes the redundant authorize call while maintaining the
AuthorizedPaymentsProcessor::CAPTURED_META_KEYmeta update call, which is necessary for the manual renewal action to be displayed.This change will only affect vaulted subscription renewals. Since these renewals always use tokens as the payment source, no explicit authorization call is required.