Skip to content

Fix E2E #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Fix E2E #360

wants to merge 2 commits into from

Conversation

faisal-alvi
Copy link
Collaborator

@faisal-alvi faisal-alvi commented Jun 3, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Steps to test the changes in this Pull Request:

Make sure the automated and manual tests pass.

Changelog entry

Add - Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Closes #372

@vikrampm1
Copy link
Collaborator

@faisal-alvi just checking if there is anything else needed here or probably missed requesting review?

@vikrampm1
Copy link
Collaborator

@dkotter the create issue GH action is still failing here as I think the code was already updated.

@vikrampm1 vikrampm1 requested a review from dkotter June 25, 2025 13:08
@vikrampm1 vikrampm1 added this to the Future Release milestone Jun 25, 2025
Copy link

This is linked to GitHub issue #372.

@dkotter
Copy link
Collaborator

dkotter commented Jun 25, 2025

@dkotter the create issue GH action is still failing here as I think the code was already updated.

This PR was created prior to those fixes being merged in. I merged in latest changes from trunk and it's working now.

Though seems the actual fixes from this PR have already been merged in another PR and the only changes now are a spacing fix and a code comment update. I think it's fine to merge those changes in but no need for QA or UAT on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for PR #360: Fix E2E
3 participants