feat: Internationlization #120
Draft
+1,523
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilized for script requests.
Standardized logging within the code.
The editor no longer implicitly starts.
Simplify configuration with examples.
Consistently name utility files as objects.
Consistently name utility files as objects.
Required to ensure imported files have the correct locale set.
Ensure all project-specific strings are translated.
Two benefits: 1. Align with Gutenberg 2. Use the existing translation
Required to ensure imported files have the correct locale set.
Clarify the utility's purpose.
In order to set the locale before critical `@wordpress` packages load, we must load i18n packages separately from the rest of the `@wordpress` packages. Otherwise, the locale will not be set in time and/or we will encounter collisions from loading packages more than once.
These feel like two separate concerns. Separating them hopefully reduces complexity.
Two, distinct levels provided little-to-no value.
Prefixing with the log level duplicates browser log level styles. Prefixing the project name or acronym at least provides additional context.
dcalhoun
force-pushed
the
feat/internationalization
branch
from
1d43f80 to
948dc37
Compare
It's unclear why this manual chunk configuration is required, but the editor fails to load without it. The dynamic import of the module never resolves.
There is no reason to attempt loading the default locale. There will never be a translation file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add internationalization (i18n) support.
Why?
Ref CMM-280. Close #110. I18n improves the editor usability.
How?
Download and utilize translation strings from translate.wordpress.org.
Testing Instructions
TBD
Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast
N/A, no visual changes.