WordPress.com News images don't show in the reader #21713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21713-059da6b | |
| Commit | 059da6b | |
| Direct Download | wordpress-prototype-build-pr21713-059da6b.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21713-059da6b | |
| Commit | 059da6b | |
| Direct Download | jetpack-prototype-build-pr21713-059da6b.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21713 +/- ##
=======================================
Coverage 39.41% 39.41%
=======================================
Files 2122 2122
Lines 99570 99570
Branches 15324 15324
=======================================
Hits 39247 39247
Misses 56844 56844
Partials 3479 3479 ☔ View full report in Codecov by Sentry. |
|
dcalhoun
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21709
In the issue it was noted that featured images from WordPress.com News failed to appear in the reader detail. In researching the problem, it turned out these images don't appear in the reader list or photo viewer either.
Logcat showed this whenever loading a featured image:
It seems that WordPress.com News images do a 301 (permanent) redirect, and our
CustomRedirectInterceptorfailed to close the previous response here before proceeding with the redirect. Correcting this fixed the problem with WordPress.com News images.It should be noted that
CustomRedirectInterceptoris used in more places than just the reader so there is a possibility of unintended consequences, but I left this PR in draft for several days and noticed no issues while testing. My assumption is this likely also fixes similar issues elsewhere in the app. Note that I P2'd about this at paqN3M-1oQ-p2 but received no feedback.To test:
Note: Right now featured images aren't shown edge-to-edge. This will be handled separately.