Skip to content

Remove not-needed permissions for the Camera function #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Jul 24, 2024

Closes: #81

The pictures are saved to our own folder, so we don't need any permissions to read them, and the Camera app is granted permissions to write to them via the FileProvider.

Testing

For testing, please check the WCAndroid PR woocommerce/woocommerce-android#12127

The pictures are saved to our own folder, so we don't need any permissions to read them, and the Camera app is granted permissions to write to them via the FileProvider.
@hichamboushaba hichamboushaba added the bug Something isn't working label Jul 24, 2024
@hichamboushaba hichamboushaba marked this pull request as ready for review July 24, 2024 14:33
@hichamboushaba hichamboushaba requested a review from irfano July 24, 2024 14:34
@JorgeMucientes JorgeMucientes self-assigned this Jul 24, 2024
@hichamboushaba hichamboushaba merged commit 0af39de into trunk Jul 24, 2024
13 checks passed
@hichamboushaba hichamboushaba deleted the issue/81-fix-camera-permissions branch July 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taking pictures using the camera doesn't work without storage permission on API < 29
2 participants