refactor: Use GutenbergKit configuration builder #24662
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopt the latest patterns to embrace immutable configuration.
Generated by 🚫 Danger |
|
dcalhoun
commented
Jul 9, 2025
Comment on lines
+335
to
+340
| // TODO: `setEditorSettings` throws due to incompatibility between `[String: Any]` | ||
| // and `[String: Encodable]`. The latter is now expected by | ||
| // `GutenbergKitConfiguration.EditorSettings`. How should we reconcile this? | ||
| let updatedConfig = self.editorViewController.configuration.toBuilder() | ||
| .setEditorSettings(settings) | ||
| .build() |
There was a problem hiding this comment.
@crazytonyli would you please help me determine a reasonable approach for managing type safety of fetching editor settings from the API endpoint and passing it to GutenbergKit?
GutenbergKit was updated in wordpress-mobile/GutenbergKit#146 to now expect [String: Encodable] rather than [String: Any]. This seems like a sound change, but my lack of Swift experience inhibits me from determining an appropriate solution for the logic here in WP-iOS.
Please feel free to push directly to this branch if that is easiest. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adopt the latest patterns for embracing immutable configuration introduced in wordpress-mobile/GutenbergKit#146.
Testing instructions
Smoke test editor functionality dependent upon configuration—theme styles, media uploads, remote editor (plugins), etc.