WCW-4460: implement Direct connect feature #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porkchop
reviewed
May 22, 2025
| }, timeout) | ||
|
|
||
| const signPromise = this.mobileAppConnect.signTransaction(resolved.request.getRawActions(), { | ||
| broadcast: false, |
There was a problem hiding this comment.
@thien-hoang-opskins this looks like it solves the issue of the developer having to set the braadcast field to false, no?
There was a problem hiding this comment.
@porkchop not yet, there will be a separate commit onto SessionKit it self to support broadcasting by our side
includenull
reviewed
May 22, 2025
includenull
reviewed
May 22, 2025
includenull
reviewed
May 22, 2025
includenull
reviewed
May 22, 2025
thien-hoang-opskins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.