-
Notifications
You must be signed in to change notification settings - Fork 151
rfc: grpc field resolvers #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
} | ||
|
||
message ResolveUserPostsInput { | ||
string id = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to namespace keys and args, otherwise you'll have naming conflicts.
3. **List Resolvers**: Return arrays of values or objects | ||
4. **Custom Scalar Resolvers**: Handle custom scalar types like Date, JSON, etc. | ||
|
||
### Benefits of Field Resolvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a single of these benefits looks like a valid benefit to me.
Looks more like AI generated.
RFC for using GraphQL field resolvers in the gRPC datasource