Fix SIMD fallback code when AVX2 is not available #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncf
reviewed
Jun 22, 2024
| #define __m256i mm256i_emu | ||
| typedef __m256i real_m256i; |
There was a problem hiding this comment.
Doesn't this simply become typedef mm256i_emu real_m256i after preprocessing?
There was a problem hiding this comment.
Yes, but mm256i_emu is also used in other places. I just wanted to fix the code with the least changes possible to make it easy to review.
There was a problem hiding this comment.
But if both are always the same type, there wouldn't be any need to define this union (which is only relevant when __AVX2__ is not defined but __AVX__ is).
Note: I'm not familiar with the codebase, just started exploring for a project. Just pointing out a logical inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code first
typedefs a fallback type based on__m256iand only on the following line it actually defines__m256ias the emulated type. This needs to be the other way around!This PR also adds a basic .gitignore for the recently-added downloaded model files.