forked from damsfx/valet-windows
-
Notifications
You must be signed in to change notification settings - Fork 5
Release v4.0.0 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yCodeTech
wants to merge
13
commits into
master
Choose a base branch
from
release/4.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release v4.0.0 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directory - Move all drivers into a new `Drivers` directory within the `Valet` directory so they can be autoloaded by PSR-4. - Separate the specific drivers into a new `Specific` subdirectory of `Drivers`, and leave the basic and laravel drivers in the `Drivers` directory. - Namespace all driver classes as `Valet\Drivers` or `Valet\Drivers\Specific`. - Add `use` declarations for classes that need to be used within another class.
… namespaced drivers. These legacy drivers are deprecated by default as of v3.2.0.
- Move `require.php` into `includes` directory and rename it to `require-drivers.php` and change the require reference in `server.php`. - Add the directory loop to require all legacy drivers.
…ring concatenation to interpolation - Remove extra spaces in the all driver's docblock params, and separate the params from the return and description. - Convert string concatenation to string interpolation. eg. $sitePath . '/web/app/' -> "$sitePath/web/app/" or "{$sitePath}/web/app/"
…r into it's own class, and simplify both - Extract functionality for basic driver with a public directory into it's own class `BasicWithPublicValetDriver`, and simplify both classes. - Removed now redundant methods.
…th` method for some drivers - Add `beforeLoading` method. - Move most `$_SERVER` variables for many drivers into the new method. - Remove the now unused `$sitename` param from the `serverScript` method in `Typo3ValetDriver`.
- Add new public `composerRequires` method to the base `ValetDriver` class. - Remove the private `composerRequiresSculpin` method from `SculpinValetDriver`, and update it's reference to use the new global `composerRequires` method.
…rs using the new namespaces. - Remove listing the specific drivers individually, which would be a maintenance nightmare for new drivers. - Add new `specificDrivers` method to bulk map the specific drivers into the array using the namespace.
This leverages the existing `.valet-env.php` file capability, but just adds the Valet Home directory as a first-lookup location. So, now Valet will check for `.valet-env.php` in: - `~/.config/valet/` - then the current project folder
…ivers\Custom` - Add namespace to the sample custom driver, and a `use` declaration to make sure the `ValetDriver` is available in this custom class. - Add new `customDrivers` method to bulk map the custom drivers from the `~.config/valet/Drivers` directory into the drivers array using the new namespace of `Valet\Drivers\Custom`.
convert string concatenation to interpolation
When PHP files other than `index.php` exist in `/public/` this allows them to be served by the Laravel driver.
3126b0a
to
f978e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.