Skip to content

Pool for decoders #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* Supported pool of decoders
* Added virtualtimestamps field to cdc description

## v3.99.10
Expand Down
58 changes: 47 additions & 11 deletions internal/topic/topicreadercommon/decoders.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,35 +5,71 @@ import (
"errors"
"fmt"
"io"
"sync"

"github.com/ydb-platform/ydb-go-sdk/v3/internal/grpcwrapper/rawtopic/rawtopiccommon"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
)

type decoderPool struct {
pool sync.Pool
}

func (p *decoderPool) Get() io.Reader {
dec, _ := p.pool.Get().(io.Reader)

return dec
}

func (p *decoderPool) Put(dec io.Reader) {
p.pool.Put(dec)
}

func newDecoderPool() *decoderPool {
return &decoderPool{
pool: sync.Pool{},
}
}

type DecoderMap struct {
m map[rawtopiccommon.Codec]PublicCreateDecoderFunc
m map[rawtopiccommon.Codec]PublicCreateDecoderFunc
dp map[rawtopiccommon.Codec]*decoderPool
}

func NewDecoderMap() DecoderMap {
return DecoderMap{
m: map[rawtopiccommon.Codec]PublicCreateDecoderFunc{
rawtopiccommon.CodecRaw: func(input io.Reader) (io.Reader, error) {
return input, nil
},
rawtopiccommon.CodecGzip: func(input io.Reader) (io.Reader, error) {
return gzip.NewReader(input)
},
},
dm := DecoderMap{
m: make(map[rawtopiccommon.Codec]PublicCreateDecoderFunc),
dp: make(map[rawtopiccommon.Codec]*decoderPool),
}

dm.AddDecoder(rawtopiccommon.CodecRaw, func(input io.Reader) (io.Reader, error) {
return input, nil
})

dm.AddDecoder(rawtopiccommon.CodecGzip, func(input io.Reader) (io.Reader, error) {
return gzip.NewReader(input)
})

return dm
}

func (m *DecoderMap) AddDecoder(codec rawtopiccommon.Codec, createFunc PublicCreateDecoderFunc) {
m.m[codec] = createFunc
m.dp[codec] = newDecoderPool()
}

func (m *DecoderMap) Decode(codec rawtopiccommon.Codec, input io.Reader) (io.Reader, error) {
if f := m.m[codec]; f != nil {
return f(input)
decoder := m.dp[codec].Get()
if decoder == nil {
var err error
decoder, err = f(input)
if err != nil {
return nil, err
}
}

return decoder, nil
}

return nil, xerrors.WithStackTrace(xerrors.Wrap(
Expand Down
51 changes: 51 additions & 0 deletions internal/topic/topicreadercommon/decoders_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
package topicreadercommon

import (
"bytes"
"compress/gzip"
"errors"
"io"
"testing"

"github.com/stretchr/testify/require"

"github.com/ydb-platform/ydb-go-sdk/v3/internal/grpcwrapper/rawtopic/rawtopiccommon"
)

func TestDecoderMap(t *testing.T) {
decoderMap := NewDecoderMap()

t.Run("DecodeRaw", func(t *testing.T) {
data := []byte("test data")
reader := bytes.NewReader(data)

decodedReader, err := decoderMap.Decode(rawtopiccommon.CodecRaw, reader)
require.NoError(t, err)

result, err := io.ReadAll(decodedReader)
require.NoError(t, err)
require.Equal(t, data, result)
})

t.Run("DecodeGzip", func(t *testing.T) {
data := []byte("test data")
var buf bytes.Buffer
gzipWriter := gzip.NewWriter(&buf)
_, err := gzipWriter.Write(data)
require.NoError(t, err)
require.NoError(t, gzipWriter.Close())

decodedReader, err := decoderMap.Decode(rawtopiccommon.CodecGzip, &buf)
require.NoError(t, err)

result, err := io.ReadAll(decodedReader)
require.NoError(t, err)
require.Equal(t, data, result)
})

t.Run("DecodeUnknownCodec", func(t *testing.T) {
_, err := decoderMap.Decode(rawtopiccommon.Codec(999), bytes.NewReader([]byte{}))
require.Error(t, err)
require.True(t, errors.Is(err, ErrPublicUnexpectedCodec))
})
}
Loading