added json unmarshaler for castTo #1825
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1825 +/- ##
==========================================
- Coverage 70.81% 70.74% -0.07%
==========================================
Files 386 386
Lines 40234 40252 +18
==========================================
- Hits 28492 28477 -15
- Misses 10575 10596 +21
- Partials 1167 1179 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asmyasnikov
reviewed
Jul 1, 2025
| @@ -1369,6 +1370,16 @@ func (v jsonValue) castTo(dst any) error { | |||
| case *[]byte: | |||
| *vv = xstring.ToBytes(string(v)) | |||
|
|
|||
| return nil | |||
| case json.Unmarshaler: | |||
There was a problem hiding this comment.
Не хватает тестов на эти типы - хотя бы для того, чтобы в будущем не сломать эту функциональность
asmyasnikov
reviewed
Jul 1, 2025
There was a problem hiding this comment.
Не хватает строчки в CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
-
What is the new behavior?
query.Row.ScanStruct supports json.Marshaller, but it does not work in the reverse direction (when receiving data from the database), for this purpose I add json.Unmarshaler for convenient work with QueryClient.
Other information
-