Skip to content

Bugfix: set max_active_partitions on topic creation #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

Eistern
Copy link

@Eistern Eistern commented Jun 27, 2025

This PR fixes createTopic method logic
Previously, topics were created without actual max_active_partitions setting


Also added integration tests for create/alter topic with autopartitioning
Removed @Ignore annotation because current latest YDB container tag supports topic autopartitioning

@Eistern Eistern marked this pull request as ready for review June 27, 2025 09:21
@alex268
Copy link
Member

alex268 commented Jun 27, 2025

Duplicate of #511 ?

@Eistern
Copy link
Author

Eistern commented Jun 27, 2025

Duplicate of #511 ?

Yeah, didn't notice that
But this PR also contains integration tests for autopartitioning topics

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.27%. Comparing base (583dc0e) to head (6930733).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #512      +/-   ##
============================================
+ Coverage     60.16%   61.27%   +1.11%     
- Complexity     2265     2303      +38     
============================================
  Files           328      328              
  Lines         13437    13438       +1     
  Branches       1343     1343              
============================================
+ Hits           8084     8234     +150     
+ Misses         4746     4569     -177     
- Partials        607      635      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 merged commit dea0d9d into ydb-platform:master Jun 27, 2025
10 checks passed
@Eistern Eistern deleted the bugfix/set-max-active-partitions branch June 28, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants