Skip to content

Added information about metrics for columnshards #21479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added information about metrics for columnshards #21479

wants to merge 5 commits into from

Conversation

anton-bobkov
Copy link
Collaborator

Changelog category

  • Documentation

@anton-bobkov anton-bobkov requested a review from a team as a code owner July 22, 2025 10:23
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 22, 2025
@github-actions GitHub Actions
Copy link

🟢 2025-07-22 10:25:40 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 10:26:32 UTC Pre-commit check linux-x86_64-release-asan for 80af78b has started.
⚪ 2025-07-22 10:27:00 UTC Artifacts will be uploaded here
⚪ 2025-07-22 10:30:10 UTC ya make is running...
🟢 2025-07-22 10:30:16 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-22 10:30:22 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 10:27:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 80af78b has started.
⚪ 2025-07-22 10:27:24 UTC Artifacts will be uploaded here
⚪ 2025-07-22 10:29:55 UTC ya make is running...
🟢 2025-07-22 10:30:01 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-22 10:30:07 UTC Build successful.

@anton-bobkov anton-bobkov requested a review from SloNN July 22, 2025 10:31
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (8)

⚠️ ru/concepts/vector_search.md: 57: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/concepts/vector_search.md: 58: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 130: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 131: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/reference/configuration/index.md: 711: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 712: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Секция конфигурации feature_flags {#feature_flags}"]

⚠️ ru/reference/configuration/index.md: 720: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 721: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "### Функциональные флаги"]

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 08:15:48 UTC Pre-commit check linux-x86_64-release-asan for 6f81737 has started.
⚪ 2025-07-23 08:16:16 UTC Artifacts will be uploaded here
⚪ 2025-07-23 08:19:13 UTC ya make is running...
🟢 2025-07-23 08:19:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 08:19:26 UTC Build successful.

@ydbot
Copy link
Collaborator

ydbot commented Jul 23, 2025

🔄 New commits pushed — @ElenaAfina please take a look.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 08:17:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6f81737 has started.
⚪ 2025-07-23 08:17:45 UTC Artifacts will be uploaded here
⚪ 2025-07-23 08:20:14 UTC ya make is running...
🟢 2025-07-23 08:20:20 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 08:20:26 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (8)

⚠️ ru/concepts/vector_search.md: 57: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/concepts/vector_search.md: 58: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 130: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 131: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/reference/configuration/index.md: 711: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 712: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Секция конфигурации feature_flags {#feature_flags}"]

⚠️ ru/reference/configuration/index.md: 720: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 721: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "### Функциональные флаги"]

@ydbot
Copy link
Collaborator

ydbot commented Jul 23, 2025

Hey @ElenaAfina, it has been 26 business-hours since the author's last update, could you please review?

ElenaAfina
ElenaAfina requested changes Jul 23, 2025
View reviewed changes
anton-bobkov
anton-bobkov commented Jul 23, 2025
View reviewed changes
@ydbot
Copy link
Collaborator

ydbot commented Jul 23, 2025

🔄 New commits pushed — @ElenaAfina please take a look.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 14:56:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 916021f has started.
⚪ 2025-07-23 14:57:07 UTC Artifacts will be uploaded here
⚫ 2025-07-23 14:58:00 UTC Check cancelled

@ydbot
Copy link
Collaborator

ydbot commented Jul 23, 2025

🔄 New commits pushed — @ElenaAfina please take a look.

ElenaAfina
ElenaAfina requested changes Jul 23, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 15:04:33 UTC Pre-commit check linux-x86_64-release-asan for 6d9164e has started.
⚪ 2025-07-23 15:05:03 UTC Artifacts will be uploaded here
⚪ 2025-07-23 15:08:05 UTC ya make is running...
🟢 2025-07-23 15:08:11 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 15:08:18 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 15:04:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6d9164e has started.
⚪ 2025-07-23 15:05:08 UTC Artifacts will be uploaded here
⚪ 2025-07-23 15:07:35 UTC ya make is running...
🟢 2025-07-23 15:07:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 15:07:47 UTC Build successful.

ElenaAfina
ElenaAfina approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@ElenaAfina ElenaAfina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ElenaAfina
ElenaAfina previously requested changes Jul 23, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 15:36:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 72cc38d has started.
⚪ 2025-07-23 15:36:54 UTC Artifacts will be uploaded here
⚪ 2025-07-23 15:39:16 UTC ya make is running...
🟢 2025-07-23 15:39:21 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 15:39:28 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 15:37:06 UTC Pre-commit check linux-x86_64-release-asan for 72cc38d has started.
⚪ 2025-07-23 15:37:20 UTC Artifacts will be uploaded here
⚪ 2025-07-23 15:39:50 UTC ya make is running...
🟢 2025-07-23 15:39:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 15:40:02 UTC Build successful.

@ydbot
Copy link
Collaborator

ydbot commented Jul 23, 2025

🔄 New commits pushed — @ElenaAfina please take a look.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (8)

⚠️ ru/concepts/vector_search.md: 57: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/concepts/vector_search.md: 58: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 130: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 131: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/reference/configuration/index.md: 711: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 712: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Секция конфигурации feature_flags {#feature_flags}"]

⚠️ ru/reference/configuration/index.md: 720: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 721: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "### Функциональные флаги"]

@blinkov blinkov added the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

⚪ 2025-07-28 03:41:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3e7c083 has started.
⚪ 2025-07-28 03:41:33 UTC Artifacts will be uploaded here
⚪ 2025-07-28 03:44:03 UTC ya make is running...
🟢 2025-07-28 03:44:08 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-28 03:44:15 UTC Build successful.

@ydbot
Copy link
Collaborator

ydbot commented Jul 28, 2025

🔄 New commits pushed — @ElenaAfina please take a look.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

⚪ 2025-07-28 03:44:11 UTC Pre-commit check linux-x86_64-release-asan for 3e7c083 has started.
⚪ 2025-07-28 03:44:26 UTC Artifacts will be uploaded here
⚪ 2025-07-28 03:46:56 UTC ya make is running...
🟢 2025-07-28 03:47:02 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-28 03:47:08 UTC Build successful.

@blinkov blinkov enabled auto-merge (squash) July 28, 2025 04:01
@blinkov blinkov dismissed ElenaAfina’s stale review July 28, 2025 04:01

no open comments left

@ydbot
Copy link
Collaborator

ydbot commented Aug 7, 2025

Heads-up: it's been 11 business-days since a reviewer comment. @anton-bobkov, any updates? @ElenaAfina, please check the status with the author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaAfina ElenaAfina ElenaAfina left review comments

@SloNN SloNN Awaiting requested review from SloNN

At least 1 approving review is required to merge this pull request.

Assignees

@ElenaAfina ElenaAfina

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anton-bobkov @ydbot @ElenaAfina @blinkov