-
Notifications
You must be signed in to change notification settings - Fork 703
Make TQueueInplace and TOneOneQueueInplace usable without an extra pointer #21488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TQueueInplace and TOneOneQueueInplace usable without an extra pointer #21488
Conversation
🟢 |
64e43dd
to
208bbc8
Compare
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
208bbc8
to
9ee9f03
Compare
9ee9f03
to
8c4239f
Compare
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
This PR makes it possible to specify a deleter for TOneOneQueueInplace when storing pointers, which alleviates the need for custom smart pointers. Also it makes TQueueInplace use constructors and destructors for its elements, which allows storing non-default-constructible and non-assignable types inplace, similar to standard containers.
Additionally this PR replaces indirect TOneOneQueueInplace uses with a direct TDelete specifier, and replaces single-threaded TOneOneQueueInplace with TQueueInplace.