Skip to content

Fix unnecessary tablet resolver negative caching on pipe disconnects #21621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

snaury
Copy link
Member

@snaury snaury commented Jul 24, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Fix in #20931 introduced a subtle bug with negative caching for tablets after a disconnect. This bug is subtle because this negative caching only triggers under heavy load and not observable otherwise. Avoid negative caching unless we got definitely negative/outdated response from state storage.

Support for #21053.

@snaury snaury self-assigned this Jul 24, 2025
Copy link

github-actions bot commented Jul 24, 2025

2025-07-24 11:28:32 UTC Pre-commit check linux-x86_64-release-asan for 5cfae26 has started.
2025-07-24 11:28:44 UTC Artifacts will be uploaded here
2025-07-24 11:32:00 UTC ya make is running...
🟡 2025-07-24 13:23:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15241 14877 0 75 268 21

🟢 2025-07-24 13:24:26 UTC Build successful.
🟢 2025-07-24 13:24:53 UTC ydbd size 3.9 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: db28c16 merge: 5cfae26 diff diff %
ydbd size 4 219 127 520 Bytes 4 219 131 896 Bytes +4.3 KiB +0.000%
ydbd stripped size 1 462 104 280 Bytes 1 462 105 816 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 24, 2025

2025-07-24 11:29:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5cfae26 has started.
2025-07-24 11:29:40 UTC Artifacts will be uploaded here
2025-07-24 11:33:08 UTC ya make is running...
🟡 2025-07-24 12:59:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37691 34904 0 1 2749 37

2025-07-24 13:03:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-24 13:16:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
685 (only retried tests) 581 0 0 77 27

🟢 2025-07-24 13:16:13 UTC Build successful.
🟢 2025-07-24 13:16:34 UTC ydbd size 2.2 GiB changed* by +2.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: db28c16 merge: 5cfae26 diff diff %
ydbd size 2 399 612 456 Bytes 2 399 614 976 Bytes +2.5 KiB +0.000%
ydbd stripped size 501 767 752 Bytes 501 768 520 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-07-24 11:30:16 UTC The validation of the Pull Request description is successful.

@snaury snaury marked this pull request as ready for review July 25, 2025 11:04
@snaury snaury enabled auto-merge (squash) July 25, 2025 11:05
@snaury snaury merged commit 40cb259 into ydb-platform:main Jul 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants