Skip to content

Removed unused BalancerTabletID #21648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2025
Merged

Removed unused BalancerTabletID #21648

merged 4 commits into from
Jul 28, 2025

Conversation

nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested a review from a team as a code owner July 24, 2025 15:14
@github-actions GitHub Actions
Copy link

🟢 2025-07-24 15:17:07 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2025 •
edited
Loading

⚪ 2025-07-24 15:17:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for ff865b2 has started.
⚪ 2025-07-24 15:18:03 UTC Artifacts will be uploaded here
⚪ 2025-07-24 15:21:58 UTC ya make is running...
🔴 2025-07-24 15:58:47 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2025 •
edited
Loading

⚪ 2025-07-24 15:17:59 UTC Pre-commit check linux-x86_64-release-asan for ff865b2 has started.
⚪ 2025-07-24 15:18:14 UTC Artifacts will be uploaded here
⚪ 2025-07-24 15:22:18 UTC ya make is running...
🔴 2025-07-24 16:07:36 UTC Build failed, see the logs. Also see fail summary

@nshestakov nshestakov enabled auto-merge (squash) July 24, 2025 15:32
CyberROFL
CyberROFL previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно ничего не отвалится?)

@nshestakov nshestakov requested a review from a team as a code owner July 26, 2025 05:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2025 •
edited
Loading

⚪ 2025-07-26 05:47:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 69e10a3 has started.
⚪ 2025-07-26 05:48:00 UTC Artifacts will be uploaded here
⚪ 2025-07-26 05:51:51 UTC ya make is running...
🔴 2025-07-26 06:29:28 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2025 •
edited
Loading

⚪ 2025-07-26 05:47:59 UTC Pre-commit check linux-x86_64-release-asan for 69e10a3 has started.
⚪ 2025-07-26 05:48:13 UTC Artifacts will be uploaded here
⚪ 2025-07-26 05:51:56 UTC ya make is running...
🔴 2025-07-26 06:28:23 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2025 •
edited
Loading

⚪ 2025-07-26 08:48:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for c9f164e has started.
⚪ 2025-07-26 08:48:46 UTC Artifacts will be uploaded here
⚪ 2025-07-26 08:52:40 UTC ya make is running...
🟡 2025-07-26 10:23:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39123 36326 0 6 2753 38

⚪ 2025-07-26 10:27:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-26 10:40:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1053 (only retried tests) 950 0 1 78 24

⚪ 2025-07-26 10:40:52 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-26 10:52:44 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
263 (only retried tests) 191 0 1 49 22

🟢 2025-07-26 10:52:52 UTC Build successful.
🟢 2025-07-26 10:53:14 UTC ydbd size 2.2 GiB changed* by -2.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c641bf9 merge: c9f164e diff diff %
ydbd size 2 403 138 552 Bytes 2 403 135 536 Bytes -2.9 KiB -0.000%
ydbd stripped size 502 224 264 Bytes 502 223 496 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2025 •
edited
Loading

⚪ 2025-07-26 08:48:48 UTC Pre-commit check linux-x86_64-release-asan for c9f164e has started.
⚪ 2025-07-26 08:49:03 UTC Artifacts will be uploaded here
⚪ 2025-07-26 08:52:46 UTC ya make is running...
🟡 2025-07-26 10:47:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16630 16256 0 86 267 21

🟢 2025-07-26 10:48:49 UTC Build successful.
🟢 2025-07-26 10:49:20 UTC ydbd size 3.9 GiB changed* by -9.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c641bf9 merge: c9f164e diff diff %
ydbd size 4 225 095 952 Bytes 4 225 086 136 Bytes -9.6 KiB -0.000%
ydbd stripped size 1 463 473 016 Bytes 1 463 466 712 Bytes -6.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2025 •
edited
Loading

⚪ 2025-07-27 06:42:00 UTC Pre-commit check linux-x86_64-release-asan for 5860b0f has started.
⚪ 2025-07-27 06:42:14 UTC Artifacts will be uploaded here
⚪ 2025-07-27 06:50:29 UTC ya make is running...
🟡 2025-07-27 08:46:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16630 16262 0 85 263 20

🟢 2025-07-27 08:48:08 UTC Build successful.
🟢 2025-07-27 08:48:36 UTC ydbd size 3.9 GiB changed* by -9.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 77fff9b merge: 5860b0f diff diff %
ydbd size 4 225 096 448 Bytes 4 225 086 632 Bytes -9.6 KiB -0.000%
ydbd stripped size 1 463 473 016 Bytes 1 463 466 712 Bytes -6.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2025 •
edited
Loading

⚪ 2025-07-27 06:42:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5860b0f has started.
⚪ 2025-07-27 06:42:20 UTC Artifacts will be uploaded here
⚪ 2025-07-27 06:50:48 UTC ya make is running...
🟡 2025-07-27 08:18:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39140 36352 0 6 2752 30

⚪ 2025-07-27 08:22:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-27 08:34:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
546 (only retried tests) 437 0 0 84 25

🟢 2025-07-27 08:35:08 UTC Build successful.
🟢 2025-07-27 08:35:27 UTC ydbd size 2.2 GiB changed* by -2.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 77fff9b merge: 5860b0f diff diff %
ydbd size 2 403 138 904 Bytes 2 403 135 888 Bytes -2.9 KiB -0.000%
ydbd stripped size 502 224 264 Bytes 502 223 496 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov
Copy link
Collaborator Author

Точно ничего не отвалится?)

Отвалились тесты. Ввалил их обратно. :)

@nshestakov nshestakov requested a review from CyberROFL July 27, 2025 10:08
@nshestakov nshestakov merged commit 9c9e21f into ydb-platform:main Jul 28, 2025
12 checks passed
@nshestakov nshestakov deleted the PQ-remove-unused-field branch July 28, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@alexnick88 alexnick88 alexnick88 approved these changes

@FloatingCrowbar FloatingCrowbar Awaiting requested review from FloatingCrowbar FloatingCrowbar is a code owner automatically assigned from ydb-platform/topics

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nshestakov @CyberROFL @alexnick88