Skip to content

Fixed releasing of non locked partitions #21650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Jul 24, 2025

Changelog entry

Редко могли случаться verify при чтении по протоколу pqv0 во время балансировки партиции

Changelog category

  • Bugfix

Description for reviewers

Verify was replaced by closing the session
LOGBROKER-9759

#21412

@nshestakov nshestakov requested a review from a team as a code owner July 24, 2025 15:41
@nshestakov nshestakov changed the title Verify was replaced by closing the session Verify was replaced by closing the read session Jul 24, 2025
Copy link

github-actions bot commented Jul 24, 2025

2025-07-24 15:43:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for c04faba has started.
2025-07-24 15:43:20 UTC Artifacts will be uploaded here
2025-07-24 15:46:08 UTC ya make is running...
🔴 2025-07-24 15:48:33 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jul 24, 2025

2025-07-24 15:43:24 UTC Pre-commit check linux-x86_64-release-asan for c04faba has started.
2025-07-24 15:43:39 UTC Artifacts will be uploaded here
2025-07-24 15:46:26 UTC ya make is running...
🔴 2025-07-24 15:49:00 UTC Build failed, see the logs. Also see fail summary

@nshestakov nshestakov changed the title Verify was replaced by closing the read session Fixed releasing of non locked partitions Jul 24, 2025
Copy link

github-actions bot commented Jul 24, 2025

🟢 2025-07-28 08:33:01 UTC The validation of the Pull Request description is successful.

alexnick88
alexnick88 previously approved these changes Jul 24, 2025
maximyurchuk
maximyurchuk previously approved these changes Jul 28, 2025
@nshestakov nshestakov dismissed stale reviews from maximyurchuk and alexnick88 via 4ead9a6 July 28, 2025 09:16
Copy link

github-actions bot commented Jul 28, 2025

2025-07-28 09:19:46 UTC Pre-commit check linux-x86_64-release-asan for e4d6b44 has started.
2025-07-28 09:20:01 UTC Artifacts will be uploaded here
2025-07-28 09:22:53 UTC ya make is running...
🟡 2025-07-28 10:41:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12244 12074 0 26 106 38

2025-07-28 10:42:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-28 11:03:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 153 0 4 16 35

2025-07-28 11:03:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-07-28 11:24:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
83 (only retried tests) 36 0 3 11 33

🟢 2025-07-28 11:24:22 UTC Build successful.
🟢 2025-07-28 11:24:52 UTC ydbd size 3.7 GiB changed* by +17.5 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 60342a8 merge: e4d6b44 diff diff %
ydbd size 4 019 862 688 Bytes 4 019 880 568 Bytes +17.5 KiB +0.000%
ydbd stripped size 1 402 116 312 Bytes 1 402 120 984 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 28, 2025

2025-07-28 09:19:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for e4d6b44 has started.
2025-07-28 09:20:09 UTC Artifacts will be uploaded here
2025-07-28 09:22:53 UTC ya make is running...
🟡 2025-07-28 10:22:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19165 17877 0 3 1239 46

2025-07-28 10:24:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-28 10:44:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 60 0 0 6 38

🟢 2025-07-28 10:44:48 UTC Build successful.
🟢 2025-07-28 10:45:05 UTC ydbd size 2.2 GiB changed* by +11.4 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 60342a8 merge: e4d6b44 diff diff %
ydbd size 2 309 565 408 Bytes 2 309 577 056 Bytes +11.4 KiB +0.001%
ydbd stripped size 485 242 880 Bytes 485 245 248 Bytes +2.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov enabled auto-merge July 29, 2025 10:18
@nshestakov nshestakov merged commit c382a67 into ydb-platform:stable-25-1 Jul 29, 2025
12 checks passed
@nshestakov nshestakov deleted the PQ-verify-25-1 branch July 29, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants