Slot allocator #22213
Merged
Slot allocator #22213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdrynkin
force-pushed
the
slot_alloc
branch
2 times, most recently
from
7aae5e7 to
66585cd
Compare
dcherednik
reviewed
Aug 4, 2025
| @@ -128,6 +128,11 @@ namespace NInterconnect::NRdma { | |||
| return mr->rkey; | |||
| } | |||
|
|
|||
| void TMemRegion::Resize(uint32_t newSize) { | |||
| Chains[GetChainIndex(1 << i)].Init(1 << i); | ||
| } | ||
| } | ||
| ~TSlotMemPoolCache() { |
There was a problem hiding this comment.
We need to return Chain in to global pool. In real case sets of threads is changed during pdisk restart.
| Stopped = true; | ||
| } | ||
| TMemRegion* AllocImpl(int size, ui32 flags, TSlotMemPool& pool) noexcept { | ||
| Y_UNUSED(flags); |
There was a problem hiding this comment.
We need to support alignment of start address.
| @@ -5,10 +5,13 @@ | |||
| #include <ydb/library/actors/interconnect/rdma/ibdrv/include/infiniband/verbs.h> | |||
|
|
|||
| #include <util/thread/lfstack.h> | |||
| #include <util/thread/lfqueue.h> | |||
There was a problem hiding this comment.
I think we do not need it if lfstack is used
dcherednik
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
...
Changelog category
Description for reviewers
...