[wip] autopartitioning of mirrored topics #22221
Conversation
|
🟢 |
ydb/core/persqueue/partition.cpp
Outdated
| ctx.Send(ev->Get()->Sender, new TEvPQ::TEvPartitionStatusResponse(result, Partition)); | ||
| } | ||
|
|
||
| void TPartition::Handle(TEvPQ::TEvPartitionScaleStatusChanged::TPtr& ev, const TActorContext& ctx) | ||
| { | ||
| const bool mirroredPartition = Config.GetPartitionConfig().HasMirrorFrom(); |
There was a problem hiding this comment.
Кажется ты для этого выделил MirrorFromEnabled
| } | ||
|
|
||
| void TPartitionScaleManager::HandleScaleStatusChange(const ui32 partitionId, NKikimrPQ::EScaleStatus scaleStatus, const TActorContext& ctx) { | ||
| TString TPartitionScaleManager::LogPrefix() const { |
There was a problem hiding this comment.
А зачем partitionId переименовывать в partition? У тебя и в TPartitionScaleOperationInfo называется PartitionId :)
ydb/core/persqueue/pq_impl.cpp
Outdated
| @@ -5111,6 +5111,12 @@ void TPersQueue::Handle(TEvPQ::TEvReadingPartitionStatusRequest::TPtr& ev, const | |||
|
|
|||
| void TPersQueue::Handle(TEvPQ::TEvPartitionScaleStatusChanged::TPtr& ev, const TActorContext& ctx) | |||
| { | |||
| const bool mirroredPartition = Config.GetPartitionConfig().HasMirrorFrom(); | |||
There was a problem hiding this comment.
И тут MirrorFromEnabled
There was a problem hiding this comment.
и тут точно надо что то логировать?
если надо . то может для всех сообщений?
| mirrorer_ut.cpp | ||
| topic_ut.cpp | ||
| ) | ||
|
|
||
| NO_OPTIMIZE() |
There was a problem hiding this comment.
а это что бы стеки нормально отображались?
ubyte
force-pushed
the
mirror-autopart-old
branch
from
0e0d8ed to
00b5681
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...