-
Notifications
You must be signed in to change notification settings - Fork 48
Update s2125.csv #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update s2125.csv #217
Conversation
Added external temperature sensors BT1, BT25 and BT71
Hey @DavidNordin, Can you please also provide source CSV from where you got this data. |
yes ofcource. There are more I can input but these were important now: sincerely, |
|
Can you please change your pump language to English and do registers export as CSV. https://github.com/yozik04/nibe?tab=readme-ov-file#1b-for-s-serires-pumps We cannot use a PDF as source. Only for verification. |
|
@DavidNordin Looking into your PR. In the PR title you specify S2125, but CSV that you have added in the last commit has a name of |
I can explain what blocks me from merging this. I cannot access the PDF you have referred to, it shows 404 for me. You can attach it here if you still have it. In the attached |
@yozik04 updated link below, these registers are not exported similar to #227, at least on my s1256. @DavidNordin did you get these sensors in your export csv or did you add them manually? https://headless.nibe.eu/download/18.3bd9d98318c457ffd811678/1703680919076/M12676EN2.pdf |
I always add them manually when I get changes from Nibe (I work with them so I always get fast answers). Exports rarely work as expected, instead integrators rely on tables in textfiles, such as the one listed from bj00rn. Perhaps it might make sense with versions of software now since there's an increased amount of changes ahead. |
Nice doc. Will need to try to throw a Copilot to process it. |
@DavidNordin I recently added External room sensor in #217 (comment) by adding it to extensions.json instead of patching the csv. Just note the that the register id here is not the actual modbus register, but 40000 + 1 + [MODBUS_REGISTER]. For BT1 That would be -> 40000 + 1 + 5217 = 45218 etc |
Should be same doc i talked about here: #56 but newer revision. |
First do we know which document is the latest one? I seem to find multiple ones. I did have a go at parsing it with pdfplumber, its possible to work with font sizes and traverse pages to find tables Page 18 "External sensors" goes away from the previous format of tables, and just list the IDs with descriptions. Its not that its impossible to extract info from the doc, but the above situation makes it almost useless in my own opinion. So many fixups and cornercases needed. I have seen multiple historical versions of a similar document and from time to time the format is changed, changes like this would break a parser, that needs to handle all strange cases from above. I'd say the existing json and csv in this repo are in a much better state than what NIBE release in their document. I understand that those are mostly exported by the individual heatpumps. There is a issue that the output from the particular heatpump is tailored accordning to configuration and language. (Theoretically we could benefit from localized descriptions, but lets focus on English.) Idea: What do you think of reverse enginer the binaries to extract modbus tables? Surely there must be some table with descriptions and IDs atleast?! |
For S-series all CSV's are exported from individual heat pumps. For F-Series I get CSVs from modbus manager. I do manual merging every time somebody sends a new version for S series. I do not like the process. It should be done very diligently because sometimes CSV files also contain invalid data. I'd keep it all as simple as possible. But if it is possible to reverse engineer it would be interesting to try. But I do not think I want to spend so much time on it myself. |
Added external temperature sensors BT1, BT25 and BT71