-
-
Notifications
You must be signed in to change notification settings - Fork 356
chore/unformatted exceptions #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
d-v-b
merged 17 commits into
zarr-developers:main
from
d-v-b:chore/unformatted-exceptions
Aug 29, 2025
Merged
chore/unformatted exceptions #3403
d-v-b
merged 17 commits into
zarr-developers:main
from
d-v-b:chore/unformatted-exceptions
Aug 29, 2025
+187
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/unformatted-exceptions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
==========================================
+ Coverage 94.89% 94.92% +0.03%
==========================================
Files 79 79
Lines 9501 9503 +2
==========================================
+ Hits 9016 9021 +5
+ Misses 485 482 -3
🚀 New features to boost your workflow:
|
maxrjones
reviewed
Aug 28, 2025
Co-authored-by: Max Jones <[email protected]>
…-b/zarr-python into chore/unformatted-exceptions
This looks good, I think a test just needs updating for my suggestion of a more informative error message. I'll approve once the tests pass |
@maxrjones tests are green |
maxrjones
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses #3402 by allowing all of the zarr-specific exceptions take a single argument, which will be treated as a pre-formatted message. The old behavior, in which an exception would take multiple arguments and use them to format a canned message, is still available by passing in multiple arguments. I don't know how to deprecate this visibly, but I also suspect the API of
zarr.errors
is not a load-bearing member for many downstream projects.While changing the exceptions in
zarr.errors
, I found more exceptions defined inzarr.core.indexing
. I moved those definitions tozarr.errors
, because all our errors should be defined in one place, barring a strong reason otherwise. Had all the errors been defined in place, I wouldn't have needed to use a text search to discover the additional errors inzarr.core.indexing
.