Fix Extension Hijacking and Dashboard URLs #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… local setup instructions, and adjust Dockerfile for new version. Add node_modules to .vscodeignore and update dependencies in package-lock.json.
…ty with new commands, and add ZenML tutorial view. Adjust Dockerfile and .vscodeignore for new versioning. Improve logging for extension activation.
…ctionality, and add auto-open tutorial feature. Adjust Dockerfile and package files accordingly. Improve error handling and logging during activation.
…nd package files accordingly, and add codicon.css for icon support. Modify .vscodeignore to exclude node_modules and update build workflow for new versioning.
…in the binary file.
…ocally and renumber steps for clarity.
…in package files, Dockerfile, and build workflow for consistent versioning across all components.
htahir1
approved these changes
Jul 11, 2025
htahir1
requested changes
Jul 11, 2025
|
|
||
| # Determine base URL based on environment | ||
| is_codespace = os.environ.get("CODESPACES") == "true" | ||
| is_tutorial_enabled = os.environ.get("ZENML_ENABLE_TUTORIAL") == "true" |
There was a problem hiding this comment.
this would be set by default in codespaces containers
| if is_codespace or is_tutorial_enabled or is_remote: | ||
| dashboard_base = "https://cloud.zenml.io" | ||
| else: | ||
| dashboard_base = "http://127.0.0.1:8237" |
There was a problem hiding this comment.
Well it isnt always local is it? The server url can be an OSS URL?
There was a problem hiding this comment.
what's an OSS url?
There was a problem hiding this comment.
@safoinme open source deployment of the server
There was a problem hiding this comment.
how can we know that url? is it already defined like the 2 in top? if not users can change it via extension settings https://open-vsx.org/extension/zenml-io/zenml-tutorial#%F0%9F%94%A7-settings-json
There was a problem hiding this comment.
cant we somehow fetch it? im not sure myself... maybe the way you describe it is the way to go @safoinme
…o package files, Dockerfile, and README for improved user guidance and consistent versioning across components.
…in package files, build workflow, and the addition of the new VSIX file for consistent versioning across all components.
…in package files, Dockerfile, build workflow, and the addition of the new VSIX file for consistent versioning across all components.
…sistency and improved dependency management.
…uding @azure/core-auth, @azure/core-client, @azure/core-rest-pipeline, and others, ensuring compatibility with Node.js 20 and improving overall package management.
…in package files, Dockerfile, build workflow, and the addition of the new VSIX file for consistent versioning across all components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.