Skip to content

chore(1.x): fix rector set list for rector 2 #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented May 22, 2025

fixes #784

I just wanted to make this rector set compatible with rector 2, because I'll use this code to create the future rector set we'll need for #899

@nikophil nikophil force-pushed the fix/1.x-rector-2 branch from 13339b9 to 6d4c374 Compare May 22, 2025 07:55
@nikophil nikophil changed the title chore: fix rector set list for rector 2 chore(1.x): fix rector set list for rector 2 May 22, 2025
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is rector 1 still supported?

@nikophil
Copy link
Member Author

Is rector 1 still supported?

no it's not, but I don't think it is a problem, do you?

By the way, Foundry 2 is finally becoming more popular than Foundry 1 😅

image

@kbond
Copy link
Member

kbond commented May 23, 2025

but I don't think it is a problem, do you?

Nope, I was just curious

@nikophil nikophil merged commit 720b595 into zenstruck:1.x May 23, 2025
19 checks passed
@nikophil nikophil deleted the fix/1.x-rector-2 branch May 23, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants