-
Notifications
You must be signed in to change notification settings - Fork 7.4k
drivers: i2c: Add I2C driver support for Renesas RX #89553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
quytranpzz
commented
May 6, 2025
•
edited
Loading
edited
- Add I2C driver support for Renesas RX with r_riic_rx on RDP (Renesas driver package) for RSK-RX130
- Add I2C property node on RSK-RX130 board
- Add overlay for tests/samples/ of I2C driver
e3cd4c7
to
d3fa4fc
Compare
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
d3fa4fc
to
909300c
Compare
drivers/i2c/i2c_renesas_rx_riic.c
Outdated
return 0; | ||
} | ||
|
||
static const struct i2c_driver_api i2c_rx_driver_api = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either natively implement .submit or assign it to the fallback as other drivers have done, sensors are moving to the asynchronous design that will take advantage of this. Native implementation of submit will save firmware one or more thread stacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I corrected it to use DEVICE_API.
Thank you.
dts/bindings/i2c/renesas,rx-i2c.yaml
Outdated
interrupt-names: | ||
required: true | ||
|
||
clock-frequency: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is included in i2c-controller.yaml already and shouldn't be here. If you need specific frequencies create BUILD_ASSERT's in your driver to validate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I removed this property in the yaml file. Thank you.
Update commit ID for I2C driver support on hal_renesas Signed-off-by: Quy Tran <[email protected]>
Add initial support for i2c on Renesas RX MCU This driver is controlling the RIIC HW of RX MCU for i2c bus interface on Zephyr Only master mode is supported Signed-off-by: Duy Nguyen <[email protected]>
This commit add support for I2C node on RSK-RX130 board Signed-off-by: Duy Nguyen <[email protected]>
Add overlay and config for RSK-RX130 to execute i2c_api test Signed-off-by: Duy Nguyen <[email protected]>
909300c
to
101285e
Compare
|