Skip to content

drivers: i2c: Add I2C driver support for Renesas RX #89553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

quytranpzz
Copy link
Contributor

@quytranpzz quytranpzz commented May 6, 2025

  • Add I2C driver support for Renesas RX with r_riic_rx on RDP (Renesas driver package) for RSK-RX130
  • Add I2C property node on RSK-RX130 board
  • Add overlay for tests/samples/ of I2C driver

@quytranpzz quytranpzz force-pushed the rx_zephyr_i2c_support branch from e3cd4c7 to d3fa4fc Compare May 6, 2025 16:50
Copy link

github-actions bot commented May 6, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_renesas zephyrproject-rtos/hal_renesas@9d68ee7 zephyrproject-rtos/hal_renesas#94 zephyrproject-rtos/hal_renesas#94/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 6, 2025
@quytranpzz quytranpzz marked this pull request as ready for review May 8, 2025 04:04
@github-actions github-actions bot requested a review from teburd May 8, 2025 04:05
@quytranpzz quytranpzz force-pushed the rx_zephyr_i2c_support branch from d3fa4fc to 909300c Compare May 16, 2025 07:30
@github-actions github-actions bot requested a review from duynguyenxa May 16, 2025 07:31
return 0;
}

static const struct i2c_driver_api i2c_rx_driver_api = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either natively implement .submit or assign it to the fallback as other drivers have done, sensors are moving to the asynchronous design that will take advantage of this. Native implementation of submit will save firmware one or more thread stacks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected it to use DEVICE_API. Thank you.

interrupt-names:
required: true

clock-frequency:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in i2c-controller.yaml already and shouldn't be here. If you need specific frequencies create BUILD_ASSERT's in your driver to validate it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I removed this property in the yaml file. Thank you.

quytranpzz and others added 4 commits May 19, 2025 17:36
Update commit ID for I2C driver support on hal_renesas

Signed-off-by: Quy Tran <[email protected]>
Add initial support for i2c on Renesas RX MCU
This driver is controlling the RIIC HW of RX MCU for i2c bus
interface on Zephyr
Only master mode is supported

Signed-off-by: Duy Nguyen <[email protected]>
This commit add support for I2C node on RSK-RX130 board

Signed-off-by: Duy Nguyen <[email protected]>
Add overlay and config for RSK-RX130 to execute i2c_api test

Signed-off-by: Duy Nguyen <[email protected]>
@quytranpzz quytranpzz force-pushed the rx_zephyr_i2c_support branch from 909300c to 101285e Compare May 19, 2025 13:56
@quytranpzz quytranpzz requested a review from teburd May 19, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: I2C area: RX DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_renesas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants