-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Bluetooth: Add missing depends on for stack size Kconfig #90048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bluetooth: Add missing depends on for stack size Kconfig #90048
Conversation
Thanks for this! It's been annoying me as well that these show up in |
There are few more of these unused stack sizes... will get to them too only I get current CI happy. |
drivers/bluetooth/hci/Kconfig
Outdated
default 256 | ||
help | ||
Stack size for the HCI driver's TX thread. | ||
|
||
config BT_DRV_RX_STACK_SIZE | ||
int | ||
depends on BT_H4 || BT_H5 || BT_SPI || BT_HCI_RAW_H4 || BT_AMBIQ_HCI || BT_STM32_IPM || HCI_NXP_RX_THREAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more maintainable/scalable solution for something like this is to define a virtual option that you depend on, and then each driver (that needs this) selects that virtual option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to have each of the drivers define their own Kconfig variable? Is there a reason it makes sense to have a shared variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair point. Driver specific options should be fine as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to have each of the drivers define their own Kconfig variable? Is there a reason it makes sense to have a shared variable?
Not sure of the history behind the common BT_DRV_RX_STACK_SIZE
being used, but some of the vendors already has driver specific rx stack size values defined, that is being assigned to this shared Kconfig.
f8c1f8e
to
0192e97
Compare
40a4410
to
133f446
Compare
Add missing depends on for stack size Kconfig values. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
133f446
to
1b9bca2
Compare
|
Add missing depends on for stack size Kconfig values.